Fix documentation on swarm connect. #1229
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's not clearer. it just adds "direct"! what does it mean? why is it useful? is it to bypass nats? what sort of connexion does it make? an http? TCP? which port? at least refering to something like external documentation might make this usage actually useful. :) |
|
@anarcat it dials to a peer by a given multiaddr, the transport method is defined by the multiaddr. All it does is ensure that you have a connection to the peer in question. The only other thing i can see adding would be some sort of link to multiaddr docs |
jbenet
added a commit
that referenced
this pull request
May 15, 2015
Fix documentation on swarm connect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #873.
A small change to get my feet wet and used to the code base. =)