Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added P2P tunnel part for OpenComputers. #1410

Merged
merged 1 commit into from
May 9, 2015

Conversation

fnuecke
Copy link
Contributor

@fnuecke fnuecke commented May 7, 2015

See #579.

Fixed the PR, now against master, also some small improvements (e.g. made it use the dynamic tick handling instead of rescheduling to check for connections each time it failed, so that should be nicer).

Re-tested and looking good.

@fnuecke fnuecke force-pushed the master branch 2 times, most recently from fc28673 to cdcfd12 Compare May 7, 2015 21:05
@thatsIch
Copy link
Member

thatsIch commented May 7, 2015

So far looks good, I am testing it tomorrow,
you doing quick work! :D

@yueh
Copy link
Contributor

yueh commented May 7, 2015

GridFlags.COMPRESSED_CHANNEL might not be necessary. Except you want to prevent them from being tunneled through another network. But besides ME no other tunnel has this limitation.

@fnuecke
Copy link
Contributor Author

fnuecke commented May 7, 2015

GridFlags.COMPRESSED_CHANNEL

Ah, right. I oriented myself on the ME tunnel for the IGridTickable implementation and copied that over for testing, forgot to remove it again. Removed it.

@fnuecke
Copy link
Contributor Author

fnuecke commented May 7, 2015

Also, if you test with OC the way I did (computer on one end, screen on the other), in particular that it keeps working after exiting and re-entering the world, make sure to use the latest OC dev build's OpenOS. Depending on the time it takes for things to initialize on chunk load, there was a scenario where GPUs could forget about their screens, but the screens could be back before the computer resumed for the first time, leading to the OS assuming the GPU was still aware of its screen, where it really wasn't. Fixed that in OpenOS now. So this implementation turned out to be a really good test case for that behavior!

@thatsIch
Copy link
Member

thatsIch commented May 9, 2015

Tested it, working fine for me,
send you a PR which you can merge,
this includes some style fixes and other random crap, the commit message should help

@fnuecke
Copy link
Contributor Author

fnuecke commented May 9, 2015

Merged, thanks for the cleanup!

@thatsIch
Copy link
Member

thatsIch commented May 9, 2015

just rebase -i them out. I think thats just nicer and faster than somebody bossing around to fix this and that

Includes cleanup provided by thatsIch.
@fnuecke
Copy link
Contributor Author

fnuecke commented May 9, 2015

Sure thing, done!

thatsIch added a commit that referenced this pull request May 9, 2015
Added P2P tunnel part for OpenComputers.
@thatsIch thatsIch merged commit e99680d into AppliedEnergistics:master May 9, 2015
@thatsIch
Copy link
Member

thatsIch commented May 9, 2015

Thank you for your contribution!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants