-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added P2P tunnel part for OpenComputers. #1410
Conversation
fc28673
to
cdcfd12
Compare
So far looks good, I am testing it tomorrow, |
|
Ah, right. I oriented myself on the ME tunnel for the |
Also, if you test with OC the way I did (computer on one end, screen on the other), in particular that it keeps working after exiting and re-entering the world, make sure to use the latest OC dev build's OpenOS. Depending on the time it takes for things to initialize on chunk load, there was a scenario where GPUs could forget about their screens, but the screens could be back before the computer resumed for the first time, leading to the OS assuming the GPU was still aware of its screen, where it really wasn't. Fixed that in OpenOS now. So this implementation turned out to be a really good test case for that behavior! |
Tested it, working fine for me, |
Merged, thanks for the cleanup! |
just |
Includes cleanup provided by thatsIch.
Sure thing, done! |
Added P2P tunnel part for OpenComputers.
Thank you for your contribution! |
See #579.
Fixed the PR, now against master, also some small improvements (e.g. made it use the dynamic tick handling instead of rescheduling to check for connections each time it failed, so that should be nicer).
Re-tested and looking good.