Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 271a3f70eb8b
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a6f53270e2e3
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on May 12, 2015

  1. Fix #844

    @vais
    vais committed May 12, 2015
    Copy the full SHA
    441afe8 View commit details

  2. Merge pull request #845 from vais/fix-issue-844 

    Fix #844 - compiling block arguments creates global variables
    @elia
    elia committed May 12, 2015

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Learn about vigilant mode
    Copy the full SHA
    a6f5327 View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/opal/nodes/iter.rb
2 changes: 1 addition & 1 deletion lib/opal/nodes/iter.rb
View file
Original file line number Diff line number Diff line change
@@ -67,7 +67,7 @@ def compile_args(args, opt_args, params)
elsif arg.type == :array
arg[1..-1].each_with_index do |_arg, _idx|
_arg = variable(_arg[1])
push "#{_arg} = #{params[idx]}[#{_idx}];"
push "var #{_arg} = #{params[idx]}[#{_idx}];"
end
else
raise "Bad block arg type"