opal · May 16, 2015 · May 16, 2015 · May 16, 2015 · May 16, 2015
Showing with 70 additions and 38 deletions.

+46 −0 .jshintrc

+5 −0 .travis.yml

+1 −0 Rakefile

+0 −38 tasks/documentation.rake

+18 −0 tasks/linting.rake
diff --git a/.jshintrc b/.jshintrc
@@ -0,0 +1,46 @@
+{
+  // http://jshint.com/docs/options
+
+  "curly"         : true, // Require curly braces around blocks in loops and conditionals
+  "eqeqeq"        : true, // Prohibit the use of == and != in favor of === and !==
+  "es3"           : true, // Adhere to ECMAScript 3 specification
+  "forin"         : true, // Require all for in loops to filter object's items (hasOwnProperty)
+  "latedef"       : true, // Prohibit the use of a variable before it was defined
+  "noarg"         : true, // Prohibit the use of arguments.caller and arguments.callee
+  "nonbsp"        : true, // Warn about "non-breaking whitespace" characters
+  "undef"         : true, // Prohibit the use of explicitly undeclared variables
+  "unused"        : true, // Warn when you define and never use your variables
+
+  "globals": {
+    "Opal": true
+  },
+
+  // Currently the following checks are failing:
+
+  "-W003": false, // 'variable' was used before it was defined
+  "-W004": false, // 'variable' is already defined
+  "-W018": false, // Confusing use of '!'
+  "-W021": false, // '$ClassName' is a function
+  "-W024": false, // Expected an identifier and instead saw 'eval' (a reserved word)
+  "-W027": false, // Unreachable ';' after 'return'
+  "-W032": false, // Unnecessary semicolon
+  "-W030": false, // Expected an assignment or function call and instead saw an expression
+  "-W033": false, // Missing semicolon
+  "-W038": false, // 'variable' used out of scope
+  "-W041": false, // Use '===' to compare with 'true'
+  "-W049": false, // Unexpected escaped character '<' in regular expression
+  "-W053": false, // Do not use String as a constructor
+  "-W058": false, // Missing '()' invoking a constructor
+  "-W061": false, // eval can be harmful
+  "-W065": false, // Missing radix parameter
+  "-W069": false, // ['prop'] is better written in dot notation
+  "-W080": false, // It's not necessary to initialize 'result' to 'undefined'
+  "-W083": false, // Don't make functions within a loop
+  "-W086": false, // Expected a 'break' statement before 'case'
+  "-W089": false, // The body of a for in should be wrapped in an if statement to filter unwanted properties from the prototype
+  "-W093": false, // Did you mean to return a conditional instead of an assignment?
+  "-W098": false, // 'variable' is defined but never used
+  "-W116": false, // Expected '===' and instead saw '=='
+  "-W117": false, // 'variable' is not defined
+  "-W120": false  // You might be leaking a variable ($ClassName) here
+}
diff --git a/.travis.yml b/.travis.yml
@@ -30,6 +30,11 @@ matrix:
     - rvm: jruby-head
       env: RUN=rspec
 
+    - rvm: 2.2
+      script:
+        - npm install -g jshint
+        - bundle exec rake lint
+
   allow_failures:
     - rvm: 1.8.7
     - rvm: 1.9.3

diff --git a/Rakefile b/Rakefile
@@ -9,5 +9,6 @@ import 'tasks/github.rake'
 import 'tasks/documenting.rake'
 import 'tasks/testing.rake'
 import 'tasks/building.rake'
+import 'tasks/linting.rake'
 
 task :default => [:rspec, :mspec_node, :cruby_tests]
diff --git a/tasks/documentation.rake b/tasks/documentation.rake
diff --git a/tasks/linting.rake b/tasks/linting.rake
@@ -0,0 +1,18 @@
+directory 'tmp/lint'
+
+desc "Build *corelib* and *stdlib* and lint the result"
+task :lint => 'tmp/lint' do
+  require 'opal/sprockets/environment'
+
+  env = Opal::Environment.new
+
+  files = Dir['{opal,stdlib}/*.rb'].map { |lib| File.basename(lib, '.rb') }
+
+  files.each do |lib|
+    next if lib == 'minitest'
+    File.binwrite("tmp/lint/#{lib}.js", env[lib].to_s)
+  end
+
+  sh "jshint --verbose tmp/lint/*.js"
+end
+