Skip to content

Commit 33a633a

Browse files
committedMay 15, 2015
Fix libgmp for Android
Android terminated immediately after start since commit 181f7ba because library wasn't loaded, and libminetest.so required libgmp.so.10 instead of libgmp.so. The second issue has been solved by the linker flags.
1 parent be18bd6 commit 33a633a

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed
 

Diff for: ‎build/android/Makefile

+3-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ CURL_URL_HTTP = http://curl.haxx.se/download/curl-${CURL_VERSION}.tar.bz2
120120

121121
GMP_VERSION = 6.0.0
122122
GMP_DIR = $(ROOT)/deps/gmp-$(GMP_VERSION)
123-
GMP_LIB = $(GMP_DIR)/usr/lib/libgmp.la
123+
GMP_LIB = $(GMP_DIR)/usr/lib/libgmp.so
124124
GMP_TIMESTAMP = $(GMP_DIR)/timestamp
125125
GMP_TIMESTAMP_INT = $(ROOT)/deps/gmp_timestamp
126126
GMP_URL_HTTP = https://gmplib.org/download/gmp/gmp-$(GMP_VERSION).tar.bz2
@@ -602,6 +602,8 @@ $(GMP_LIB): $(GMP_TIMESTAMP)
602602
export PATH="$${TOOLCHAIN}/bin:$${PATH}"; \
603603
export CC=${CROSS_PREFIX}gcc; \
604604
export CXX=${CROSS_PREFIX}g++; \
605+
export LIBGMP_LDFLAGS="-avoid-version"; \
606+
export LIBGMPXX_LDFLAGS="-avoid-version"; \
605607
./configure --disable-static --host=${TARGET_HOST} --prefix=/usr; \
606608
$(MAKE) install DESTDIR=/${GMP_DIR} || exit 1; \
607609
touch ${GMP_TIMESTAMP}; \

Diff for: ‎build/android/src/net/minetest/minetest/MtNativeActivity.java

+6
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,12 @@ protected void onActivityResult(int requestCode, int resultCode,
8686
System.loadLibrary("vorbis");
8787
System.loadLibrary("ssl");
8888
System.loadLibrary("crypto");
89+
System.loadLibrary("gmp");
90+
91+
// We don't have to load libminetest.so ourselves,
92+
// but if we do, we get nicer logcat errors when
93+
// loading fails.
94+
System.loadLibrary("minetest");
8995
}
9096

9197
private int m_MessagReturnCode;

0 commit comments

Comments
 (0)
Please sign in to comment.