Added support for migrating R and X 'local.fedora.server' urls. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit message should be "R and E" (redirect and external). |
| * @param idMapper the MigrationIDMapper used for the current migration scenario | ||
| */ | ||
| public SelfReferencingURLMapper(final String localFedoraServer, final MigrationIDMapper idMapper) { | ||
| this.contentPatterns = new ArrayList<Pattern>(); |
|
This PR looks good. I have some general informational comments, but nothing that requires another commit in this PR. |
mikedurbin
force-pushed
the
local-fedora-server
branch
from
a82d31f
to
b8a2d62
Compare
|
I rebased and added a commit. If you could, when you squash, could you use the commit message from the second commit. |
|
Resolved with: 3deb4d6 |
|
@mikedurbin, I missed your "squash" comment until after I already pushed the squash. Apologies. |
|
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/FCREPO-1492