Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 837cb739713e
Choose a base ref
...
head repository: jruby/jruby
compare: 5bc6c5099ac3
Choose a head ref
  • 7 commits
  • 4 files changed
  • 1 contributor

Commits on May 13, 2015

  1. do not run the spec in 1.8 mode (avoids travis-ci failures due missin… 

    …g Random)
    @kares
    kares committed May 13, 2015
    Configuration menu
    Copy the full SHA
    3ac859f View commit details
    Browse the repository at this point in the history

  2. make sure we do not confuse bytes length with end index (due ByteList… 

    … usage)

... also cleanup up the internals a bit
    @kares
    kares committed May 13, 2015
    Configuration menu
    Copy the full SHA
    72d6e80 View commit details
    Browse the repository at this point in the history

  3. adjust (inline) removing backslashes and make sure sub index is alway… 

    …s correct!
    @kares
    kares committed May 13, 2015
    Configuration menu
    Copy the full SHA
    546bc78 View commit details
    Browse the repository at this point in the history

  4. generix-ize internal iface + rename/move some var declarations

    @kares
    kares committed May 13, 2015
    Configuration menu
    Copy the full SHA
    eb48185 View commit details
    Browse the repository at this point in the history

  5. handle exception being thrown when doing a Dir['{}'] (fixes #2922) 

    ... in this case we end up with an empty path in Dir's `glob_helper` and it all seems reasonable - thuse removed the length check comment about "" ending up here
    @kares
    kares committed May 13, 2015
    Configuration menu
    Copy the full SHA
    0da8bff View commit details
    Browse the repository at this point in the history

  6. avoid the intermediate ArrayList ... create the Java array directly

    @kares
    kares committed May 13, 2015
    Configuration menu
    Copy the full SHA
    c81e3eb View commit details
    Browse the repository at this point in the history

  7. return empty Ruby array for empty dir list

    @kares
    kares committed May 13, 2015
    Configuration menu
    Copy the full SHA
    5bc6c50 View commit details
    Browse the repository at this point in the history