Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8dffcc128342
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0d18de6090cf
Choose a head ref
  • 6 commits
  • 14 files changed
  • 1 contributor

Commits on May 10, 2015

  1. Copy the full SHA
    619d636 View commit details
  2. Copy the full SHA
    6967194 View commit details
  3. Always splat the argument in Kernel#singleton_methods specs.

    * Otherwise the "when not passed an argument" case would actually pass an Array.
    eregon committed May 10, 2015
    Copy the full SHA
    8dfe557 View commit details
  4. Copy the full SHA
    1d46a31 View commit details
  5. Copy the full SHA
    d31f9b4 View commit details
  6. [Truffle] Implement and fix all Kernel#*methods.

    * Add a few well-known constant filters for MethodFilter.
    eregon committed May 10, 2015
    3
    Copy the full SHA
    0d18de6 View commit details
12 changes: 6 additions & 6 deletions spec/ruby/core/kernel/singleton_methods_spec.rb
Original file line number Diff line number Diff line change
@@ -4,27 +4,27 @@

describe :kernel_singleton_methods, :shared => true do
it "returns an empty Array for an object with no singleton methods" do
ReflectSpecs.o.singleton_methods(@object).should == []
ReflectSpecs.o.singleton_methods(*@object).should == []
end

it "returns the names of module methods for a module" do
ReflectSpecs::M.singleton_methods(@object).should include(*stasy(:ms_pro, :ms_pub))
ReflectSpecs::M.singleton_methods(*@object).should include(*stasy(:ms_pro, :ms_pub))
end

it "does not return private module methods for a module" do
ReflectSpecs::M.singleton_methods(@object).should_not include(stasy(:ms_pri))
ReflectSpecs::M.singleton_methods(*@object).should_not include(stasy(:ms_pri))
end

it "returns the names of class methods for a class" do
ReflectSpecs::A.singleton_methods(@object).should include(*stasy(:as_pro, :as_pub))
ReflectSpecs::A.singleton_methods(*@object).should include(*stasy(:as_pro, :as_pub))
end

it "does not return private class methods for a class" do
ReflectSpecs::A.singleton_methods(@object).should_not include(stasy(:as_pri))
ReflectSpecs::A.singleton_methods(*@object).should_not include(stasy(:as_pri))
end

it "returns the names of singleton methods for an object" do
ReflectSpecs.os.singleton_methods(@object).should include(*stasy(:os_pro, :os_pub))
ReflectSpecs.os.singleton_methods(*@object).should include(*stasy(:os_pro, :os_pub))
end
end

5 changes: 0 additions & 5 deletions spec/truffle/tags/core/kernel/methods_tags.txt

This file was deleted.

2 changes: 0 additions & 2 deletions spec/truffle/tags/core/kernel/private_methods_tags.txt

This file was deleted.

11 changes: 0 additions & 11 deletions spec/truffle/tags/core/kernel/protected_methods_tags.txt

This file was deleted.

4 changes: 0 additions & 4 deletions spec/truffle/tags/core/kernel/public_methods_tags.txt

This file was deleted.

33 changes: 0 additions & 33 deletions spec/truffle/tags/core/kernel/singleton_methods_tags.txt

This file was deleted.

Loading