Fixed Thread#join(timeout). Closes #3390.

brixen · brixen · commit cda061a406d8 · 2015-05-07T22:12:42.000-07:00
The thread joining would not be signaled until the timeout expired.
diff --git a/vm/builtin/thread.cpp b/vm/builtin/thread.cpp
@@ -500,11 +500,9 @@ namespace rubinius {
           struct timespec ts = {0,0};
           self->join_cond_.offset(&ts, as<Float>(timeout)->val);
 
-          for(;;) {
-            if(self->join_cond_.wait_until(self->join_lock_, &ts)
+          if(self->join_cond_.wait_until(self->join_lock_, &ts)
                 == utilities::thread::cTimedOut) {
-              return nil<Thread>();
-            }
+            return nil<Thread>();
           }
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -500,11 +500,9 @@ namespace rubinius {`
`500`	`500`	`struct timespec ts = {0,0};`
`501`	`501`	`self->join_cond_.offset(&ts, as<Float>(timeout)->val);`
`502`	`502`
`503`		`- for(;;) {`
`504`		`- if(self->join_cond_.wait_until(self->join_lock_, &ts)`
	`503`	`+ if(self->join_cond_.wait_until(self->join_lock_, &ts)`
`505`	`504`	`== utilities::thread::cTimedOut) {`
`506`		`- return nil<Thread>();`
`507`		`- }`
	`505`	`+ return nil<Thread>();`
`508`	`506`	`}`
`509`	`507`	`}`
`510`	`508`	`}`