Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add another layer of try/finally around rescue/ensure to reset $!. #2919

Closed
wants to merge 2 commits into from
Closed

Add another layer of try/finally around rescue/ensure to reset $!. #2919

wants to merge 2 commits into from
+84 −23

Conversation

headius
Copy link
Member

@headius headius commented May 8, 2015

Fixes #2910.

@headius headius force-pushed the ensure_last_error_reset branch from 2880c73 to 2a82982 Compare May 8, 2015 16:49
@headius
Copy link
Member Author

headius commented May 9, 2015

Merged to master.

@headius headius closed this May 9, 2015
@headius headius added this to the JRuby 9.0.0.0.rc1 milestone May 9, 2015
@headius headius deleted the ensure_last_error_reset branch May 9, 2015 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core ir
Projects
None yet
Milestone
JRuby 9.0.0.0.rc1
Development

Successfully merging this pull request may close these issues.

$! does not get cleared under certain circumstances
1 participant
@headius