-
-
Notifications
You must be signed in to change notification settings - Fork 925
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e0e18f154399
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e4ce2686065b
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 2 commits
- 2 files changed
- 1 contributor
Commits on May 12, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 14ae2c4 - Browse repository at this point
Copy the full SHA 14ae2c4View commit details -
Disable opttempvars for -X-C and JIT. The recent optimizations to fix…
… multiple assignment does not work with opttempvars pass anymore. In the scenario of: def s3e(y, d) y, d = d, y p y end s3e "23","1999" s3e "23","1999" jruby -X-C -Xjit.background=false -Xjit.threshold=1 ../snippets/date1.rb When full build occurs here we run LOP and then OTV. Instr.simplifyAndGetResult will remove y and d from the literal rhs Array and replace masgn_required with a %t1 = copy(y); %t2 = copy(d). Now that it is in a copy assigning to a temp var OTV will propagate y and d but this removal of these intermediary copys ends up breaking the swap since we have created something like 'y =d; d = y' so both values end up being d's value. This will affect -X-C performance in some cases (although fannkuch showed almost no difference on Java 8 but was 25% slower on Java 7). JIT performance is not affected at all and I think this is because it converts to an SSA form internally so these extra temps emitted in bytecode really don't affect the end result. I added a FIXME to look at addressing this for -X-C perf if it becomes important for other platforms like Android.
Configuration menu - View commit details
-
Copy full SHA for e4ce268 - Browse repository at this point
Copy the full SHA e4ce268View commit details
There are no files selected for viewing