-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In windows ScriptingContainerTest fails #2964
Comments
Sadly, our proposed solution leads to a different test failing, namely the 'testRequire' test in file 'org.jruby.test.TestKernel'. We have a proposed fix for that too. Consider the original method:
Changing to:
yields this in windows:
Hurrah! |
jruby#2964 On windows the mvn -Ptest fails due to incorrect substitution of '/' and '\'. See the write up for more details. Cris Shupp Greg Bowman
Thanks for your help! |
I reverted this. It made bundler stop working (surprised revert did not pop up here). I am going to suggest the right fix is to change this test. I think the main meaning of it is to see if we have the same logic File and not exact same string. So: String expResult = System.getProperty("user.dir");
String result = instance.getCurrentDirectory();
assertEquals(expResult, result); Maybe should wrap both values as java.io.File() and do some equality check that way. |
In windows the test testGetCurrentDirectory in ScriptingContainer fails as follows:
The bug appears to be here (org.jruby.util.JRubyFile):
The order of replace is backwards, changing to:
With your permission my coding partner and I would like to use this simple issue to attempt our first contribution to JRuby. Is there a check in guide we should read?
Thanks,
Cris and Greg
The text was updated successfully, but these errors were encountered: