jruby · May 20, 2015 · May 20, 2015 · May 20, 2015 · May 20, 2015 · May 20, 2015
diff --git a/lib/ruby/truffle/mri/csv.rb b/lib/ruby/truffle/mri/csv.rb
@@ -0,0 +1 @@
+require_relative '../../stdlib/csv'
diff --git a/lib/ruby/truffle/mri/drb.rb b/lib/ruby/truffle/mri/drb.rb
@@ -0,0 +1 @@
+require_relative '../../stdlib/drb'
diff --git a/lib/ruby/truffle/mri/drb/acl.rb b/lib/ruby/truffle/mri/drb/acl.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/acl'
diff --git a/lib/ruby/truffle/mri/drb/drb.rb b/lib/ruby/truffle/mri/drb/drb.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/drb'
diff --git a/lib/ruby/truffle/mri/drb/eq.rb b/lib/ruby/truffle/mri/drb/eq.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/eq'
diff --git a/lib/ruby/truffle/mri/drb/extserv.rb b/lib/ruby/truffle/mri/drb/extserv.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/extserv'
diff --git a/lib/ruby/truffle/mri/drb/extservm.rb b/lib/ruby/truffle/mri/drb/extservm.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/extsrvm'
diff --git a/lib/ruby/truffle/mri/drb/gw.rb b/lib/ruby/truffle/mri/drb/gw.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/gw'
diff --git a/lib/ruby/truffle/mri/drb/invokemethod.rb b/lib/ruby/truffle/mri/drb/invokemethod.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/invokemethod'
diff --git a/lib/ruby/truffle/mri/drb/observer.rb b/lib/ruby/truffle/mri/drb/observer.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/observer'
diff --git a/lib/ruby/truffle/mri/drb/ssl.rb b/lib/ruby/truffle/mri/drb/ssl.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/ssl'
diff --git a/lib/ruby/truffle/mri/drb/timeridconv.rb b/lib/ruby/truffle/mri/drb/timeridconv.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/timeridconv'
diff --git a/lib/ruby/truffle/mri/drb/unix.rb b/lib/ruby/truffle/mri/drb/unix.rb
@@ -0,0 +1 @@
+require_relative '../../../stdlib/drb/unix'
diff --git a/lib/ruby/truffle/shims/weakref.rb b/lib/ruby/truffle/shims/weakref.rb
@@ -0,0 +1 @@
+# Empty file
diff --git a/spec/truffle/tags/library/csv/generate_line_tags.txt b/spec/truffle/tags/library/csv/generate_line_tags.txt
@@ -0,0 +1,5 @@
+fails:CSV.generate_line generates an empty string
+fails:CSV.generate_line generates the string 'foo,bar'
+fails:CSV.generate_line generates the string 'foo;bar'
+fails:CSV.generate_line generates the string 'foo,,bar'
+fails:CSV.generate_line generates the string 'foo;;bar'
diff --git a/spec/truffle/tags/library/csv/generate_tags.txt b/spec/truffle/tags/library/csv/generate_tags.txt
@@ -0,0 +1,3 @@
+fails:CSV.generate returns CSV string
+fails:CSV.generate accepts a col separator
+fails:CSV.generate appends and returns the argument itself
diff --git a/spec/truffle/tags/library/csv/parse_tags.txt b/spec/truffle/tags/library/csv/parse_tags.txt
@@ -0,0 +1,15 @@
+fails:CSV.parse parses '' into []
+fails:"CSV.parse parses '\n' into [[]]"
+fails:CSV.parse parses 'foo' into [['foo']]
+fails:CSV.parse parses 'foo,bar,baz' into [['foo','bar','baz']]
+fails:CSV.parse parses 'foo,baz' into [[foo,nil,baz]]
+fails:"CSV.parse parses '\nfoo' into [[],['foo']]"
+fails:"CSV.parse parses 'foo\n' into [['foo']]"
+fails:"CSV.parse parses 'foo\nbar' into [['foo'],['bar']]"
+fails:"CSV.parse parses 'foo,bar\nbaz,quz' into [['foo','bar'],['baz','quz']]"
+fails:"CSV.parse parses 'foo,bar'\nbaz' into [['foo','bar'],['baz']]"
+fails:"CSV.parse parses 'foo\nbar,baz' into [['foo'],['bar','baz']]"
+fails:"CSV.parse parses '\n\nbar' into [[],[],'bar']]"
+fails:CSV.parse parses 'foo' into [['foo']] with a separator of ;
+fails:CSV.parse parses 'foo;bar' into [['foo','bar']] with a separator of ;
+fails:"CSV.parse parses 'foo;bar\nbaz;quz' into [['foo','bar'],['baz','quz']] with a separator of ;"
diff --git a/spec/truffle/tags/library/csv/readlines_tags.txt b/spec/truffle/tags/library/csv/readlines_tags.txt
@@ -0,0 +1,3 @@
+fails:CSV#readlines returns an Array of Array containing each element in a one-line CSV file
+fails:CSV#readlines returns an Array of Arrays containing each element in a multi-line CSV file
+fails:CSV#readlines returns nil for a missing value
diff --git a/spec/truffle/tags/library/drb/start_service_tags.txt b/spec/truffle/tags/library/drb/start_service_tags.txt
@@ -0,0 +1,2 @@
+fails:DRb.start_service runs a basic remote call
+fails:DRb.start_service runs a basic remote call passing a block
diff --git a/spec/truffle/tags/library/drb/stop_service_tags.txt b/spec/truffle/tags/library/drb/stop_service_tags.txt
@@ -0,0 +1 @@
+fails:DRb.stop_service clears the port so a new server can start
diff --git a/spec/truffle/tags/library/socket/basicsocket/close_read_tags.txt b/spec/truffle/tags/library/socket/basicsocket/close_read_tags.txt
@@ -0,0 +1,6 @@
+fails:Socket::BasicSocket#close_read closes the reading end of the socket
+fails:Socket::BasicSocket#close_read it works on sockets with closed ends
+fails:Socket::BasicSocket#close_read does not close the socket
+fails:Socket::BasicSocket#close_read fully closes the socket if it was already closed for writing
+fails:Socket::BasicSocket#close_read raises IOError on closed socket
+fails:Socket::BasicSocket#close_read returns nil
diff --git a/spec/truffle/tags/library/socket/basicsocket/ioctl_tags.txt b/spec/truffle/tags/library/socket/basicsocket/ioctl_tags.txt
@@ -0,0 +1 @@
+fails:Socket::BasicSocket#ioctl passes data from and to a String correctly
diff --git a/spec/truffle/tags/library/socket/constants/constants_tags.txt b/spec/truffle/tags/library/socket/constants/constants_tags.txt
@@ -0,0 +1,8 @@
+fails:Socket::Constants defines socket types
+fails:Socket::Constants defines protocol families
+fails:Socket::Constants defines address families
+fails:Socket::Constants defines send/receive options
+fails:Socket::Constants defines socket level options
+fails:Socket::Constants defines socket options
+fails:Socket::Constants defines multicast options
+fails:Socket::Constants defines TCP options
diff --git a/spec/truffle/tags/library/socket/socket/accept_nonblock_tags.txt b/spec/truffle/tags/library/socket/socket/accept_nonblock_tags.txt
@@ -0,0 +1,2 @@
+fails:Socket#accept_nonblock raises Errno::EAGAIN if the connection is not accepted yet
+fails:Socket#accept_nonblock raises IO::WaitReadable if the connection is not accepted yet
diff --git a/spec/truffle/tags/library/socket/socket/bind_tags.txt b/spec/truffle/tags/library/socket/socket/bind_tags.txt
@@ -0,0 +1,10 @@
+fails:Socket#bind on SOCK_DGRAM socket binds to a port
+fails:Socket#bind on SOCK_DGRAM socket returns 0 if successful
+fails:Socket#bind on SOCK_DGRAM socket raises Errno::EINVAL when binding to an already bound port
+fails:Socket#bind on SOCK_DGRAM socket raises Errno::EADDRNOTAVAIL when the specified sockaddr is not available from the local machine
+fails:Socket#bind on SOCK_DGRAM socket raises Errno::EACCES when the current user does not have permission to bind
+fails:Socket#bind on SOCK_STREAM socket binds to a port
+fails:Socket#bind on SOCK_STREAM socket returns 0 if successful
+fails:Socket#bind on SOCK_STREAM socket raises Errno::EINVAL when binding to an already bound port
+fails:Socket#bind on SOCK_STREAM socket raises Errno::EADDRNOTAVAIL when the specified sockaddr is not available from the local machine
+fails:Socket#bind on SOCK_STREAM socket raises Errno::EACCES when the current user does not have permission to bind
diff --git a/spec/truffle/tags/library/socket/socket/connect_nonblock_tags.txt b/spec/truffle/tags/library/socket/socket/connect_nonblock_tags.txt
@@ -0,0 +1,3 @@
+fails:Socket#connect_nonblock connects the socket to the remote side
+fails:Socket#connect_nonblock raises Errno::EINPROGRESS when the connect would block
+fails:Socket#connect_nonblock raises Errno::EINPROGRESS with IO::WaitWritable mixed in when the connect would block
diff --git a/spec/truffle/tags/library/socket/socket/for_fd_tags.txt b/spec/truffle/tags/library/socket/socket/for_fd_tags.txt
@@ -0,0 +1 @@
+fails:Socket.for_fd creates a new Socket that aliases the existing Socket's file descriptor
diff --git a/spec/truffle/tags/library/socket/socket/getaddrinfo_tags.txt b/spec/truffle/tags/library/socket/socket/getaddrinfo_tags.txt
@@ -0,0 +1,5 @@
+fails:Socket#getaddrinfo gets the address information
+fails:Socket#getaddrinfo accepts empty addresses for IPv4 passive sockets
+fails:Socket#getaddrinfo accepts empty addresses for IPv4 non-passive sockets
+fails:Socket#getaddrinfo accepts empty addresses for IPv6 passive sockets
+fails:Socket#getaddrinfo accepts empty addresses for IPv6 non-passive sockets
diff --git a/spec/truffle/tags/library/socket/socket/gethostbyname_tags.txt b/spec/truffle/tags/library/socket/socket/gethostbyname_tags.txt
@@ -0,0 +1,2 @@
+fails:Socket#gethostbyname returns broadcast address info for '<broadcast>'
+fails:Socket#gethostbyname returns broadcast address info for '<any>'
diff --git a/spec/truffle/tags/library/socket/socket/getnameinfo_tags.txt b/spec/truffle/tags/library/socket/socket/getnameinfo_tags.txt
@@ -0,0 +1,7 @@
+fails:Socket.getnameinfo gets the name information and don't resolve it
+fails:Socket.getnameinfo gets the name information and resolve the host
+fails:Socket.getnameinfo gets the name information and resolves the service
+fails:Socket.getnameinfo gets a 3-element array and doesn't resolve hostname
+fails:Socket.getnameinfo gets a 3-element array and resolves the service
+fails:Socket.getnameinfo gets a 4-element array and doesn't resolve hostname
+fails:Socket.getnameinfo gets a 4-element array and resolves the service
diff --git a/spec/truffle/tags/library/socket/socket/listen_tags.txt b/spec/truffle/tags/library/socket/socket/listen_tags.txt
@@ -0,0 +1 @@
+fails:Socket#listen verifies we can listen for incoming connections
diff --git a/spec/truffle/tags/library/socket/socket/unpack_sockaddr_in_tags.txt b/spec/truffle/tags/library/socket/socket/unpack_sockaddr_in_tags.txt
@@ -0,0 +1,2 @@
+fails:Socket#unpack_sockaddr_in decodes the host name and port number of a packed sockaddr_in
+fails:Socket#unpack_sockaddr_in raises an ArgumentError when the sin_family is not AF_INET
diff --git a/spec/truffle/truffle.mspec b/spec/truffle/truffle.mspec
@@ -88,49 +88,10 @@ class MSpecScript
   set :core, core
 
   set :library, [
-    "spec/ruby/library/abbrev",
-    "spec/ruby/library/base64",
-    "spec/ruby/library/complex",
-    "spec/ruby/library/conditionvariable",
-    "spec/ruby/library/date",
-    "spec/ruby/library/datetime",
-    "spec/ruby/library/delegate",
-    "spec/ruby/library/digest/md5",
-    "spec/ruby/library/cgi",
-    "spec/ruby/library/erb",
-    "spec/ruby/library/getoptlong",
-    "spec/ruby/library/ipaddr",
-    "spec/ruby/library/matrix",
-    "spec/ruby/library/logger",
-    "spec/ruby/library/observer",
-    "spec/ruby/library/open3",
-    "spec/ruby/library/openstruct",
-    "spec/ruby/library/pathname",
-    "spec/ruby/library/prime",
-    "spec/ruby/library/resolv",
-    "spec/ruby/library/scanf",
-    "spec/ruby/library/securerandom",
-    "spec/ruby/library/set",
-    "spec/ruby/library/shellwords",
-    "spec/ruby/library/singleton",
-    "spec/ruby/library/stringio",
-    "spec/ruby/library/stringscanner",
-    "spec/ruby/library/tempfile",
-    "spec/ruby/library/thread",
-    "spec/ruby/library/time",
-    "spec/ruby/library/tmpdir",
-    "spec/ruby/library/uri",
-    "spec/ruby/library/bigdecimal",
-    "spec/ruby/library/zlib",
+    "spec/ruby/library",
 
     # Not yet explored
     "^spec/ruby/library/continuation",
-    "^spec/ruby/library/csv",
-    "^spec/ruby/library/digest/sha1",
-    "^spec/ruby/library/digest/sha256",
-    "^spec/ruby/library/digest/sha384",
-    "^spec/ruby/library/digest/sha512",
-    "^spec/ruby/library/drb",
     "^spec/ruby/library/etc",
     "^spec/ruby/library/expect",
     "^spec/ruby/library/fiber",
@@ -144,7 +105,6 @@ class MSpecScript
     "^spec/ruby/library/weakref",
     "^spec/ruby/library/win32ole",
     "^spec/ruby/library/yaml",
-    "^spec/ruby/library/socket",
 
     # Load issues with 'delegate'.
     "^spec/ruby/library/delegate/delegate_class/instance_method_spec.rb",

diff --git a/tool/truffle-findbugs-exclude.xml b/tool/truffle-findbugs-exclude.xml
@@ -64,6 +64,13 @@
     <Bug pattern="FE_FLOATING_POINT_EQUALITY" />
   </Match>
 
+  <!-- Sometimes we really do want to compare strings by identity -->
+
+  <Match>
+    <Class name="org.jruby.truffle.nodes.constants.LookupConstantNode" />
+    <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
+  </Match>
+
   <!-- Stuff where we're genuinely doing something complicated and we do know what we're doing -->
 
   <Match>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		require_relative '../../../stdlib/drb/invokemethod'
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		require_relative '../../../stdlib/drb/observer'
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		require_relative '../../../stdlib/drb/timeridconv'
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		fails:DRb.start_service runs a basic remote call
		fails:DRb.start_service runs a basic remote call passing a block
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		fails:DRb.stop_service clears the port so a new server can start
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		fails:Socket::BasicSocket#ioctl passes data from and to a String correctly
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		fails:Socket#accept_nonblock raises Errno::EAGAIN if the connection is not accepted yet
		fails:Socket#accept_nonblock raises IO::WaitReadable if the connection is not accepted yet
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		fails:Socket.for_fd creates a new Socket that aliases the existing Socket's file descriptor
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		fails:Socket#gethostbyname returns broadcast address info for '<broadcast>'
		fails:Socket#gethostbyname returns broadcast address info for '<any>'
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		fails:Socket#listen verifies we can listen for incoming connections