Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise UncaughtThrowError for uncatched throw #3411

Closed
wants to merge 2 commits into from
Closed

Raise UncaughtThrowError for uncatched throw #3411

wants to merge 2 commits into from

Conversation

tak1n
Copy link
Member

@tak1n tak1n commented May 25, 2015

This closes #3374

Not sure if this should go first into the 2.2 branch and then be merged into master.
Feel free to close if it should go to the 2.2 branch first.

@yorickpeterse
Copy link
Contributor

If this is 2.2 specific behaviour then yes, it should go in the 2.2 branch.

@tak1n
Copy link
Member Author

tak1n commented May 25, 2015

In #3374 there is some confusion about which specific ruby version this behaviour introduced.
IMO it was 2.2 specific.

Closing this for now.
I'll create a new uncaught_throw_error branch from 2.2 as base branch and then open a new PR.

@tak1n tak1n closed this May 25, 2015
@tak1n tak1n deleted the uncaught_throw_error-3374 branch May 25, 2015 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UncaughtThrowError
2 participants
@tak1n @yorickpeterse