Skip to content

Commit

Permalink
mention that it might not be possible to render the same message twice
Browse files Browse the repository at this point in the history
  • Loading branch information
kraih committed May 16, 2015
1 parent 46b076f commit a66401d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Changes
@@ -1,5 +1,5 @@

6.11 2015-05-14
6.11 2015-05-16
- Updated jQuery to version 2.1.4.
- Fixed indentation of ASCII art in documentation browser. (jberger)
- Fixed bug where inline was not considered a reserved stash value.
Expand Down
3 changes: 2 additions & 1 deletion lib/Mojo/Message.pm
Expand Up @@ -630,7 +630,8 @@ L</"default_charset">.
my $str = $msg->to_string;
Render whole message.
Render whole message. Note that this method finalizes the message, and that it
might not be possible to render the same message twice.
=head2 upload
Expand Down

2 comments on commit a66401d

@polettix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also mean that it's not possible to get the same rendering even when no changes are done. I would suggest to change "twice" into "again with different values" or "again after setting different values".

It depends on how aggressive the optimization can become in the future of course. This message at least warns about possible weird things and it's better than before - thanks.

@kraih
Copy link
Member Author

@kraih kraih commented on a66401d May 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what it means, and what i've been trying to tell you for the last few days.

Please sign in to comment.