Don’t recheck the same remote address more than once

Fixe #1732
getnikola · May 19, 2015 · cb316c3 · felixfontein · May 20, 2015 · da2x
1 parent 7553b5a
commit cb316c3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -10,6 +10,7 @@ Features
 Bugfixes
 --------
 
+* Don’t check the same remote URL more than once (Issue #1732)
 * All remotely checked links resulted in incorrect warnings (`nikola check -lr`)
 * Exclude `<meta content="noindex" name="robots">` from sitemaps
 * new_post paths are now relative to CWD (Issue #1325)

diff --git a/nikola/plugins/command/check.py b/nikola/plugins/command/check.py
@@ -173,6 +173,7 @@ def _execute(self, options, args):
             sys.exit(1)
 
     existing_targets = set([])
+    checked_remote_targets = []
 
     def analyze(self, task, find_sources=False, check_remote=False):
         rv = False
@@ -215,11 +216,16 @@ def analyze(self, task, find_sources=False, check_remote=False):
                         ((parsed.scheme or target.startswith('//')) and url_type in ('rel_path', 'full_path')):
                     if not check_remote or parsed.scheme not in ["http", "https"]:
                         continue
-                    if parsed.netloc == base_url.netloc:
+                    if parsed.netloc == base_url.netloc:  # absolute URL to self.site
                         continue
+                    if target in self.checked_remote_targets:  # already checked this exact target
+                        continue
+                    self.checked_remote_targets.append(target)
+
                     # Check the remote link works
                     req_headers = {'User-Agent': 'Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 (Nikola)'}  # I’m a real boy!
                     resp = requests.head(target, headers=req_headers)
+
                     if resp.status_code > 399:  # Error
                         self.logger.warn("Broken link in {0}: {1} [Error {2}]".format(filename, target, resp.status_code))
                         continue