New auto #1734
Merged
New auto #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
suggestion: Will make things a bit cleaner. |
| def inject_js(self, mimetype, data): | ||
| """Inject livereload.js in HTML files.""" | ||
| if mimetype == 'text/html': | ||
| data = re.sub('</head>', self.snippet, data, 1, re.IGNORECASE) |
There was a problem hiding this comment.
</body> or add <script async …>
Note that HTML5 do not guarantee any element. It requires doctype and title only.
There was a problem hiding this comment.
I don't understand the suggestion. How would you inject it?
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
| import wsgiref.util | ||
|
|
||
| from blinker import signal | ||
| import pyinotify |
There was a problem hiding this comment.
This works on Linux only and crashes on other platforms:
Traceback (most recent call last):
File "C:\Python27\lib\site-packages\yapsy\PluginManager.py", line 484, in loadPlugins
candidate_module = imp.load_module(plugin_module_name,None,candidate_filepath,("py","r",imp.PKG_DIRECTORY))
File "C:\projects\nikola\nikola\plugins\command\auto\__init__.py", line 43, in <module>
import pyinotify
ImportError: No module named pyinotifyYou would have to find another library, like watchdog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces livereload with a homebrew version. It seems to fix #1729 and #1757 to me, and also adds a nice thing in that it shows build failures in the web page as an alert (may be too annoying ;-)
Missing bits: