Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

certain require do not load extension Service class #2986

Closed
mkristian opened this issue May 25, 2015 · 2 comments
Closed

certain require do not load extension Service class #2986

mkristian opened this issue May 25, 2015 · 2 comments
Labels
JRuby 1.7.x
Milestone
JRuby 1.7.21

Comments

@mkristian
Copy link
Member 

$ bin/jruby -e "require 'uri:classloader:/lib/ruby/shared/json/ext/parser'; p JSON::Ext::Parser"

fails. same with the file:, jar:, file:jar: protocol. the *uri:jar:file:my.jar!/" protocol does not even look into the right place place to load the Service class from the gem extension.
@mkristian
Copy link
Member Author

I was wrong about the *uri:file: protocol and the wrong place. is part of the test now. closing.

@mkristian mkristian reopened this May 26, 2015
@mkristian
Copy link
Member Author

on master this is already fixed with 764d6af

@headius either I revert this patch and backport master to jruby-1_7 or do the other way around. please also have a look at #2987

in any case I would cherry-pick the tests added with 62fa282

mkristian added a commit that referenced this issue May 26, 2015
@mkristian
add tests for #2986
d6c5cd8 
Sponsored By Lookout Inc.
mkristian added a commit that referenced this issue May 26, 2015
@mkristian
add tests for #2986
52eb669 
Sponsored By Lookout Inc.
mkristian added a commit that referenced this issue May 26, 2015
@mkristian
Revert "add tests for #2986"
7d38c5f 
This reverts commit 52eb669.
@enebo enebo added this to the JRuby 9.0.0.0.rc1 milestone Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JRuby 1.7.x
Projects
None yet
Milestone
JRuby 1.7.21
Development

No branches or pull requests
2 participants
@enebo @mkristian