Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation fixes #3402

Merged
merged 2 commits into from May 16, 2015
Merged

Minor documentation fixes #3402

merged 2 commits into from May 16, 2015

Conversation

benlovell
Copy link
Contributor

I was scanning the CONTRIBUTING guide and noticed a couple minor issues.
馃槏

I predict this will save horizontal scrolling by at least 36%. *Note*:
93% of all statistics are entirely made-up on the spot.
I noticed there was a few code/shell elements that may benefit from
being backticked. It should help one scan this guide and pick out some
of the most useful reference points.
@jemc
Copy link
Member

jemc commented May 16, 2015

I don't know if I can speak for everyone else, but I personally don't like editing markdown that is 'hard-wrapped'. Most text editors will soft-wrap it for you, and it saves you the trouble of having to add and remove newlines every time you change a word or sentence.

@benlovell
Copy link
Contributor Author

@jemc fair point, I guess it's a matter of opinion.

@yorickpeterse
Copy link
Contributor

@jemc soft wrapping is a tool for the devil, I've yet to find a single editor that can do it well. Also not everybody views Markdown on either Github or in an editor capable of soft wrapping lines. For example, I regularly read text files using less which is notoriously bad at this. As such I'd actually prefer hard wrapped lines.

Outside of that the PR looks fine to me.

yorickpeterse pushed a commit that referenced this pull request May 16, 2015
Minor documentation fixes
@yorickpeterse yorickpeterse merged commit 30d3c25 into rubinius:master May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants