Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex new 2959 #3408

Merged
merged 2 commits into from May 24, 2015
Merged

Regex new 2959 #3408

merged 2 commits into from May 24, 2015

Conversation

tak1n
Copy link
Member

@tak1n tak1n commented May 24, 2015

Not sure why @jc00ke commits were reverted, therefore opening this PR.

This closes #2959

tak1n added 2 commits May 24, 2015 12:01
Like done in @7981f2c05671722dcf12f0d4f6bceb46cef29ff5
Regexp.new should raise a TypeError if the given Pattern is an
Fixnum or Float object
@tak1n
Copy link
Member Author

tak1n commented May 24, 2015

The error for the gcc build seems unrelated to the changes in the pr:

/home/travis/build/rubinius/rubinius/spec/ruby/optional/capi/thread_spec.rb                                               F
.
.
.

1)

C-API Thread function rb_thread_create handles throwing an exception in the thread FAILED

Expected NotImplementedError

but got TypeError (wrong argument type System (expected Array))

@jemc
Copy link
Member

jemc commented May 24, 2015

@tak1n - I restarted the CI build just now - as a Collaborator you should be able to restart it too with the button on the Travis-CI page for the build.

@jemc
Copy link
Member

jemc commented May 24, 2015

Looking at the git history, I'm not sure what happened, but maybe somebody force-pushed onto master and made @jc00ke's commits disappear. Either way, I see no reason this shouldn't be merged.

If someone knows a reason why the commits were removed they can speak up and leave a better paper trail this time.

jemc added a commit that referenced this pull request May 24, 2015
@jemc jemc merged commit ffa628e into master May 24, 2015
@jemc jemc deleted the regex-new-2959 branch May 24, 2015 18:03
@tak1n
Copy link
Member Author

tak1n commented May 24, 2015

awesome thx

@jc00ke
Copy link
Member

jc00ke commented May 25, 2015

Hmm, weird. Thanks for catching it @tak1n!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error raised by Regexp.new(<integer>) differs between MRI and Rubinius
3 participants