opal · May 19, 2015 · May 19, 2015
Showing with 17 additions and 11 deletions.

+7 −1 .jshintrc

+1 −1 opal/corelib/enumerable.rb

+6 −6 opal/corelib/hash.rb

+1 −1 opal/corelib/module.rb

+1 −1 opal/corelib/runtime.js

+1 −1 stdlib/native.rb
diff --git a/.jshintrc b/.jshintrc
@@ -12,9 +12,15 @@
   "unused"        : true, // Warn when you define and never use your variables
 
   "globals": {
-    "Opal": true
+    "Opal": true,
+    "OpalNode": true,
+    "callPhantom": true,
+    "JSON": true
   },
 
+  "browser": true,
+  "node": true,
+
   // Currently the following checks are failing:
 
   "-W003": false, // 'variable' was used before it was defined

diff --git a/opal/corelib/enumerable.rb b/opal/corelib/enumerable.rb
@@ -943,7 +943,7 @@ def partition(&block)
     return enum_for :partition unless block_given?
 
     %x{
-      var truthy = [], falsy = [];
+      var truthy = [], falsy = [], result;
 
       self.$each.$$p = function() {
         var param = #{Opal.destructure(`arguments`)},

diff --git a/opal/corelib/hash.rb b/opal/corelib/hash.rb
@@ -363,7 +363,7 @@ def each_value(&block)
     %x{
       var _map = self.map,
           smap = self.smap,
-          keys = self.keys;
+          keys = self.keys, key, map, khash;
 
       for (var i = 0, length = keys.length; i < length; i++) {
         key = keys[i];
@@ -613,7 +613,7 @@ def inspect
 
         var key, value,
             inspect = [],
-            keys = self.keys
+            keys = self.keys,
             id = self.$object_id(),
             counter = 0;
 
@@ -820,7 +820,7 @@ def rassoc(object)
       var keys = self.keys,
           _map = self.map,
           smap = self.smap,
-          key, khash, value;
+          key, khash, value, map;
 
       for (var i = 0, length = keys.length; i < length; i++) {
         key = keys[i]
@@ -967,7 +967,7 @@ def select!(&block)
           smap = self.smap,
           keys = self.keys,
           result = nil,
-          key, khash, value, object;
+          key, khash, value, object, map;
 
       for (var i = 0, length = keys.length; i < length; i++) {
         key = keys[i];
@@ -1039,7 +1039,7 @@ def to_a
           _map = self.map,
           smap = self.smap,
           result = [],
-          map, key;
+          map, key, khash;
 
       for (var i = 0, length = keys.length; i < length; i++) {
         key = keys[i];
@@ -1096,7 +1096,7 @@ def values
           smap = self.smap,
           keys = self.keys,
           result = [],
-          map, khash;
+          map, khash, key;
 
       for (var i = 0, length = keys.length; i < length; i++) {
         key = keys[i];

diff --git a/opal/corelib/module.rb b/opal/corelib/module.rb
@@ -198,7 +198,7 @@ def const_defined?(name, inherit = true)
     raise NameError, "wrong constant name #{name}" unless name =~ /^[A-Z]\w*$/
 
     %x{
-      scopes = [self.$$scope];
+      var scopes = [self.$$scope];
 
       if (inherit || self === Opal.Object) {
         var parent = self.$$super;

diff --git a/opal/corelib/runtime.js b/opal/corelib/runtime.js
@@ -1155,7 +1155,7 @@
         keys = [],
         _map = {},
         smap = {},
-        key, obj, length, khash;
+        key, obj, length, khash, map;
 
     hash.map   = _map;
     hash.smap  = smap;

diff --git a/stdlib/native.rb b/stdlib/native.rb
@@ -492,7 +492,7 @@ def to_n
           keys   = self.keys,
           _map   = self.map,
           smap   = self.smap,
-          map, khash, value;
+          map, khash, value, key;
 
       for (var i = 0, length = keys.length; i < length; i++) {
         key   = keys[i];