Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor, update javadocs #796

Merged
merged 1 commit into from May 19, 2015
Merged

Minor, update javadocs #796

merged 1 commit into from May 19, 2015

Conversation

awoods
Copy link

@awoods awoods commented May 19, 2015

@@ -39,7 +39,7 @@
/**
* A very simple {@link IdentifierConverter} which translates JCR paths into Fedora subjects with
* a configurable resource namespace (e.g., a baseURL). When a REST API context is available for
* constructing URIs, {@link HttpResourceConverter} should be used instead.
* constructing URIs, org.fcrepo.http.commons.api.rdf.HttpResourceConverter should be used instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this keep the {@link ...}?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted the same thing, but fcrepo-kernel-impl does not have dependency visibility into fcrepo-http-commons.
Hence the @link syntax does not work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that makes sense, so this is good to go.

escowles added a commit that referenced this pull request May 19, 2015
@escowles escowles merged commit 1ca2dd0 into fcrepo:master May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants