Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 85090321e95a
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2aed36e799ef
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on May 23, 2015

  1. Handle all new String failures since the update to latest rubyspec

    @vais
    vais committed May 23, 2015
    Copy the full SHA
    da2abac View commit details

  2. Merge pull request #888 from vais/string 

    Handle all new String failures since the update to latest rubyspec
    @meh
    meh committed May 23, 2015
    Copy the full SHA
    2aed36e View commit details
Showing with 15 additions and 16 deletions.
  1. +2 −2 opal/corelib/kernel.rb
  2. +4 −0 opal/corelib/string/inheritance.rb
  3. +1 −1 spec/corelib
  4. +0 −13 spec/filters/bugs/string.rb
  5. +8 −0 spec/filters/unsupported/mutable_strings.rb
4 changes: 2 additions & 2 deletions opal/corelib/kernel.rb
View file
Original file line number Diff line number Diff line change
@@ -182,8 +182,8 @@ def extend(*mods)

def format(format_string, *args)
if args.length == 1 && args[0].respond_to?(:to_ary)
args = args[0].to_ary
args = args.to_a
ary = Opal.coerce_to?(args[0], Array, :to_ary)
args = ary.to_a unless ary.nil?
end

%x{
4 changes: 4 additions & 0 deletions opal/corelib/string/inheritance.rb
View file
Original file line number Diff line number Diff line change
@@ -110,4 +110,8 @@ def lines(separator = $/, &block)
e = each_line(separator, &block)
block ? self : e.to_a
end

def %(data)
@literal % data
end
end
2 changes: 1 addition & 1 deletion spec/corelib
Submodule corelib updated from 03e675 to 68afe4
13 changes: 0 additions & 13 deletions spec/filters/bugs/string.rb
View file
Original file line number Diff line number Diff line change
@@ -104,17 +104,4 @@
fails "String#dump returns a string with non-printing single-byte UTF-8 characters replaced by \\x notation"
fails "String#dump returns a string with multi-byte UTF-8 characters replaced by \\u{} notation with lower-case hex digits"
fails "String#dump includes .force_encoding(name) if the encoding isn't ASCII compatible"

fails "String#<< returns a String when given a subclass instance"
fails "String#<< returns an instance of same class when called on a subclass"
fails "String#concat returns a String when given a subclass instance"
fails "String#concat returns an instance of same class when called on a subclass"
fails "String#delete raises if the given ranges are invalid"
fails "String#% wraps the object in an Array if #to_ary returns nil"
fails "String#% raises a TypeError if #to_ary does not return an Array"
fails "String#% doesn't return subclass instances when called on a subclass"
fails "String#setbyte calls #to_int to convert the index"
fails "String#setbyte calls to_int to convert the value"
fails "String#slice! with Regexp, index accepts a Float for capture index"
fails "String#slice! with Regexp, index calls #to_int to convert an Object to capture index"
end
8 changes: 8 additions & 0 deletions spec/filters/unsupported/mutable_strings.rb
View file
Original file line number Diff line number Diff line change
@@ -99,6 +99,8 @@
fails "String#<< when self and the argument are in different ASCII-compatible encodings uses the argument's encoding if self is ASCII-only"
fails "String#<< when self and the argument are in different ASCII-compatible encodings raises Encoding::CompatibilityError if neither are ASCII-only"
fails "String#<< when self is ASCII-8BIT and argument is US-ASCII uses ASCII-8BIT encoding"
fails "String#<< returns a String when given a subclass instance"
fails "String#<< returns an instance of same class when called on a subclass"

fails "String#chomp when passed no argument returns a copy of the String when it is not modified"

@@ -203,6 +205,8 @@
fails "String#slice! with String doesn't call to_str on its argument"
fails "String#slice! with String returns a subclass instance when given a subclass instance"
fails "String#slice! with String raises a RuntimeError if self is frozen"
fails "String#slice! with Regexp, index accepts a Float for capture index"
fails "String#slice! with Regexp, index calls #to_int to convert an Object to capture index"

fails "String#[]= with Fixnum index replaces the char at idx with other_str"
fails "String#[]= with Fixnum index taints self if other_str is tainted"
@@ -317,6 +321,8 @@
fails "String#setbyte changes the byte at the given index to the new byte"
fails "String#setbyte modifies the receiver"
fails "String#setbyte returns an Integer"
fails "String#setbyte calls #to_int to convert the index"
fails "String#setbyte calls to_int to convert the value"

fails "String#prepend taints self if other is tainted"
fails "String#prepend works when given a subclass instance"
@@ -378,6 +384,8 @@
fails "String#concat when self and the argument are in different ASCII-compatible encodings uses the argument's encoding if self is ASCII-only"
fails "String#concat when self and the argument are in different ASCII-compatible encodings raises Encoding::CompatibilityError if neither are ASCII-only"
fails "String#concat when self is ASCII-8BIT and argument is US-ASCII uses ASCII-8BIT encoding"
fails "String#concat returns a String when given a subclass instance"
fails "String#concat returns an instance of same class when called on a subclass"

fails "String#dup does not modify the original string when changing dupped string"