Bug/panic on empty path #1282
Merged
Bug/panic on empty path #1282
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no path after `/ipfs/` or `/ipns/` is given, then the daemon will panic with a slice bounds out of range error. This checks to see if we have anything after `ipfs` or `ipns`.
Added the original logic to check for a invalid path and a simple test.
Cleaned the tests, and actually test for the error.
Update the previous `invalid path` error to match the error returned from `SplitAbsPath`.
|
is that.... all the tests passing?? i dont remember the last time i saw a clean test run |
|
@travisperson any idea what the problem was? why it failed on nodes? |
|
LGTM, i'll merge after comment |
|
@jbenet it was failing because i broke it. I pushed to fix a resolution bug that inadvertently broke travises test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no path after
/ipfs/or/ipns/is given, then the daemon will panic with a slice bounds out of range error. This checks to see if we have anything afteripfsoripns.Update the previous
invalid patherror to match the error returned fromSplitAbsPath.