Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Truffle] Sprintf issue in Rack #2981

Closed
bjfish opened this issue May 24, 2015 · 4 comments
Closed

[Truffle] Sprintf issue in Rack #2981

bjfish opened this issue May 24, 2015 · 4 comments
Assignees
@chrisseaton
Milestone
Non-Release

Comments

@bjfish
Copy link
Contributor

bjfish commented May 24, 2015

Found in Rack logger. Used by Sinatra.

Expected

ruby -e 'puts %{%s - %s [%s] "%s %s%s %s" %d %s %0.4f\n} % ["::1", "-", "24/May/2015:15:09:29 +0000", "GET", "/hi", "", "HTTP/1.1", "200", "14", 0.07400000000000001]'
::1 - - [24/May/2015:15:09:29 +0000] "GET /hi HTTP/1.1" 200 14 0.0740

Actual

$ jt e 'puts %{%s - %s [%s] "%s %s%s %s" %d %s %0.4f\n} % ["::1", "-", "24/May/2015:15:09:29 +0000", "GET", "/hi", "", "HTTP/1.1", "200", "14", 0.07400000000000001]'
core:/core/string.rb:12:in `sprintf': Truffle doesn't have a case for the org.jruby.truffle.pack.nodes.type.ToIntegerNodeGen node with values of type  String(org.jruby.truffle.runtime.core.RubyString) (TypeError)
    from core:/core/string.rb:12:in `%'
    from -e:1:in `<main>'
@chrisseaton
Copy link
Contributor

Note that Webrick may return bad time values at the moment, as I shimmed httpdate. Unrelated to this bug but thought I'd mention.

@chrisseaton chrisseaton self-assigned this May 24, 2015
@chrisseaton
Copy link
Contributor

Minimal test case:

puts sprintf("%d", "200")

@chrisseaton
Copy link
Contributor

Our printf isn't well tested at the moment, due to ruby/spec#68.

@chrisseaton
Copy link
Contributor

Fixed in 3b0bd45 and e5384d1

@chrisseaton chrisseaton added this to the truffle-dev milestone May 24, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisseaton chrisseaton

Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

No branches or pull requests
3 participants
@enebo @bjfish @chrisseaton