Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit declarator to role declarations #4

Merged
merged 1 commit into from Aug 27, 2015

Conversation

paultcochrane
Copy link
Contributor

As of Rakudo 2015.05, the unit declarator is required before using
module, class, role or grammar declarations (unless it uses a
block). Code still using the old blockless semicolon form will throw a
warning. This commit stops the warning from appearing in the new Rakudo.

I noticed that you'd updated some of the other unit-related issues and had done so by using the block form of the role statement, thus I've updated the remaining files similarly.

As of Rakudo 2015.05, the `unit` declarator is required before using
`module`, `class`, `role` or `grammar` declarations (unless it uses a
block).  Code still using the old blockless semicolon form will throw a
warning. This commit stops the warning from appearing in the new Rakudo.
@paultcochrane
Copy link
Contributor Author

Actually there are none, however I think that's because they're in the nyi directory and thus aren't yet run by the test suite.

cjfields added a commit that referenced this pull request Aug 27, 2015
Add unit declarator to role declarations.  Thanks to @paultcochrane !
@cjfields cjfields merged commit 9275488 into cjfields:master Aug 27, 2015
@cjfields
Copy link
Owner

I added the unit fixes to the main code base but the code in nyi is either not implemented but planned, or may not be implemented at all depending on their need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants