Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Proc#curry #3406

Merged
merged 1 commit into from May 25, 2015
Merged

fix Proc#curry #3406

merged 1 commit into from May 25, 2015

Conversation

tak1n
Copy link
Member

@tak1n tak1n commented May 23, 2015

Ported over jruby's fix for Proc#curry which can be found here: jruby/jruby#1523

brixen added a commit that referenced this pull request May 25, 2015
@brixen
Merge pull request #3406 from rubinius/proc-curry-2951
f1f0d75 
 fix Proc#curry
@brixen brixen merged commit f1f0d75 into master May 25, 2015
brixen added a commit that referenced this pull request May 25, 2015
@brixen
Added mirror for Proc#curry. Improves #3406.
93a80e0 
There is still a lot of cruft in the Rubinius kernel but generally we use the
mirror facility to implement methods that are not public Ruby API methods (and are
generally C functions in MRI).
@brixen
Copy link
Member

brixen commented May 25, 2015

@tak1n thanks for working on this patch. Take a look at the changes I made in 93a80e0 and let me know if you have any questions. You may be able to use this as a guide for your future patches.

@brixen brixen deleted the proc-curry-2951 branch May 25, 2015 05:50
@tak1n
Copy link
Member Author

tak1n commented May 25, 2015

Awesome thanks, I think I'll dig deeper into how Mirrors work and if I got some questions I'll ping you on gitter. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tak1n @brixen