Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubinius/rubinius
base: a8397f538938^
Choose a base ref
...
head repository: rubinius/rubinius
compare: a97f1979c3e3
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on May 23, 2015

  1. implement specs for comparing a method defined via define_method and … 

    …a method defined via def
    @tak1n
    tak1n committed May 23, 2015
    Copy the full SHA
    a8397f5 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2015

  1. Fix Method#== 

    A Method defined via def has an executable attribute of class
Rubinius::CompiledCode. On the other site a method defined via
define_method has an executable attribute of class
Rubinius::BlockEnvironment::AsMethod.

Comparing method equality includes the comparison of executable
equality.

For comparing an executable of type Rubinius::BlockEnvironment::AsMethod
against an executable of Rubinius::CompiledCode results in an error because it tries
to access the block_env attribute on an Rubinius::CompiledCode object,
which doesn't exist.

This commit adds an early return like in Rubinius::CompiledCode#==
    @tak1n
    tak1n committed May 24, 2015
    Copy the full SHA
    a97f197 View commit details
    Browse the repository at this point in the history