Fix Method equalitiy #3407
Merged
Fix Method equalitiy #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a method defined via def
A Method defined via def has an executable attribute of class Rubinius::CompiledCode. On the other site a method defined via define_method has an executable attribute of class Rubinius::BlockEnvironment::AsMethod. Comparing method equality includes the comparison of executable equality. For comparing an executable of type Rubinius::BlockEnvironment::AsMethod against an executable of Rubinius::CompiledCode results in an error because it tries to access the block_env attribute on an Rubinius::CompiledCode object, which doesn't exist. This commit adds an early return like in Rubinius::CompiledCode#==
| @@ -54,6 +54,16 @@ | |||
| @m_foo.send(@method, m2).should be_true | |||
| end | |||
|
|
|||
| it "returns false if comparing a method defined via define_method and def" do | |||
| MethodSpecs::Methods.send :define_method, :defined_foo, lambda {} | |||
There was a problem hiding this comment.
I think we should avoid modifying the fixtures from within the spec bodies.
It looks like MethodSpecs::Methods already has some methods defined with define_method. You could probably use one of those, or move your defined method to that file.
There was a problem hiding this comment.
True, just used it because it was used in the above spec example :)
I'll change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Method defined via def has an executable attribute of class Rubinius::CompiledCode. On the other site a method defined via define_method has an executable attribute of class Rubinius::BlockEnvironment::AsMethod.
Comparing method equality includes the comparison of executable equality.
For comparing an executable of type Rubinius::BlockEnvironment::AsMethod against an executable of Rubinius::CompiledCode results in an error because it tries to access the block_env attribute on an Rubinius::CompiledCode object, which doesn't exist.
This PR adds an early return like in Rubinius::CompiledCode#==
This closes #3118