-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ruby-2.3 feature #10769] add Enumerable#chunk_while, spec for it #3517
Conversation
0622664
to
091afe9
Compare
@eregon is it fine to have the rubyspec updates coming in like they are here? |
I saw that a similar thing was done for slice_when, so I added them. |
Ah OK - would you prefer that I remove the change? I wrote the rubyspec for this so I know there is no conflict - seems more hygienic to let the standard ruby spec import handle it though. Should I add the tests for this somewhere else? |
085961a
to
6429e6c
Compare
@eregon I removed the rubyspec change. I noticed that in ruby/ruby there was a test added for chunk_while (https://github.com/ruby/ruby/blob/trunk/test/ruby/test_enum.rb#L683) so i added it to the same place under test/mri, since that seemed to be what other folks did when they added ruby-2.3 features. |
6429e6c
to
33928b5
Compare
33928b5
to
6521c8b
Compare
add chunk_while_contiguously_increasing_integers test to test_enum.rb
6521c8b
to
aa399d4
Compare
[ruby-2.3 feature #10769] add Enumerable#chunk_while, spec for it
Thanks 👍 |
Implemented as #slice_when, but slice when block does not match rather than when it does.
Also added merged over ruby spec for it.