[ruby-2.3 feature #10769] add Enumerable#chunk_while, spec for it #3517
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhua
force-pushed
the
feature-enumerable-chunk_while
branch
from
0622664 to
091afe9
Compare
|
@eregon is it fine to have the rubyspec updates coming in like they are here? |
|
I saw that a similar thing was done for slice_when, so I added them. |
|
Ah OK - would you prefer that I remove the change? I wrote the rubyspec for this so I know there is no conflict - seems more hygienic to let the standard ruby spec import handle it though. Should I add the tests for this somewhere else? |
cthulhua
force-pushed
the
feature-enumerable-chunk_while
branch
2 times, most recently
from
085961a to
6429e6c
Compare
|
@eregon I removed the rubyspec change. I noticed that in ruby/ruby there was a test added for chunk_while (https://github.com/ruby/ruby/blob/trunk/test/ruby/test_enum.rb#L683) so i added it to the same place under test/mri, since that seemed to be what other folks did when they added ruby-2.3 features. |
cthulhua
force-pushed
the
feature-enumerable-chunk_while
branch
from
6429e6c to
33928b5
Compare
cthulhua
changed the title
cthulhua
force-pushed
the
feature-enumerable-chunk_while
branch
from
33928b5 to
6521c8b
Compare
add chunk_while_contiguously_increasing_integers test to test_enum.rb
cthulhua
force-pushed
the
feature-enumerable-chunk_while
branch
from
6521c8b to
aa399d4
Compare
kares
added a commit
that referenced
this pull request
Dec 13, 2015
[ruby-2.3 feature #10769] add Enumerable#chunk_while, spec for it
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented as #slice_when, but slice when block does not match rather than when it does.
Also added merged over ruby spec for it.