Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos and cleanup #16

Closed
wants to merge 6 commits into from
Closed

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Dec 2, 2015

minor changes: typos, grammar, formatting

@michaelni
Copy link
Member

"Each frame is composed of 1 to 4 of the following colorspace planes: Y, Cb, Cr, Alpha"
This is true for YCbCr only

@dericed
Copy link
Contributor Author

dericed commented Dec 3, 2015

Right. I also think this section needs to be changed to reflect the hierarchy of frame>slice>plane, as currently this paragraph only refers to frame and plane, and then slice arrives later in the documentation without a good introduction.

@dericed
Copy link
Contributor Author

dericed commented Dec 24, 2015

I'm reviewing this again and have some questions:

  • When the colorspace is RCT, are planes used? When I encode rgb24 with ffv1.v3 I only see one plane, but may be misinterpreting this.
  • Re: "Each frame is composed of 1 to 4 ... planes". I'd like to be more specific. From this reading it seems like 2 planes is possible but that Cb should follow Y; however, are ya colorspaces possible (grayscale with alpha)?
  • Is a 2 plane encoding possible?
  • What is the meaning of line in this paragraph? The line count appears effected by the colorspace and possibly the chroma subsampling, but I'm not clear about this.
  • Re: "since it is most likely that the RCT will immediately be converted to RGB during decoding" what other conversion is possible?

@michaelni
Copy link
Member

i dont think pull requests are the right place for such questions, theres a IETF and a ffmpeg mailing list.
Here in the pull req basically only 2 people will see it

@dericed
Copy link
Contributor Author

dericed commented Dec 31, 2015

I moved the questions to an email here: https://mailarchive.ietf.org/arch/msg/cellar/nw5nwEmfnEEBu88QSOyJbsOQu5E. It appears the commits of this PR are already in the repository so I am closing the PR.

@dericed dericed closed this Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants