Truffle new pack parser #3519
Merged
Truffle new pack parser #3519
+832
−791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Do we have any perf numbers compared to the manual parser? |
|
For the parsing itself? No - I'll do that. That's not what it's designed for of course. |
|
Yes, I recall doing one lexer with jflex for Date#strftime(format) parsing and numbers were interesting. |
|
It turns out it's quite a bit slower. final PackParser parser = new PackParser(this);
while (true) {
final long start = System.nanoTime();
for (int n = 0; n < 1_000_000; n++) {
parser.parse("LI<BaL>Q<nnD@", false);
}
System.err.println((System.nanoTime() - start) / 1e9);
}final PackCompiler compiler = new PackCompiler(this, null);
while (true) {
final long start = System.nanoTime();
for (int n = 0; n < 1_000_000; n++) {
compiler.compile("LI<BaL>Q<nnD@");
}
System.err.println((System.nanoTime() - start) / 1e9);
}I'd still rather have this nice code in there for now though, and it's not putting me off trying a Ruby parser in Antlr4. |
|
The Antlr dependency is 374 KB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is
Array#packreimplemented using Antlr instead of a hand-written lexer and parser. It's good software engineering, but it's also practice for developing a new new parser for Ruby in Antlr.@nirvdrum @pitr-ch @eregon please review - @headius and @enebo for info as you asked about this at RubyConf.