Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure due to Windows style directory separators. #33

Merged
merged 1 commit into from Aug 7, 2015

Conversation

nanis
Copy link
Contributor

@nanis nanis commented Aug 7, 2015

This fixes the following with 0.72 on Windows. See also #30.

C:\...\Inline-CPP> prove -vb t\classes\07conflict_avoid.t
t\classes\07conflict_avoid.t .. Unrecognized escape \s passed through at (eval 13) line 3.
Unrecognized escape \A passed through at (eval 13) line 3.
Unrecognized escape \T passed through at (eval 13) line 3.
Filters7744.c


not ok 1 - Foo::Bar::MyClass->can('new')#   Failed test 'Foo::Bar::MyClass->can('new')'

#   at t\classes\07conflict_avoid.t line 71.
#     Foo::Bar::MyClass->can('new') failed
not ok 2 - Foo::Bar::MyClass->new() died
#   Failed test 'Foo::Bar::MyClass->new() died'

#   at t\classes\07conflict_avoid.t line 73.
#     Error was:  Can't locate object method "new" via package "Foo::Bar::MyClass" (perhaps you forgot to load "Foo::Bar::MyClass"?) at C:/opt/perl-5.22.0/lib/
Test/More.pm line 690.
not ok 3 - Our "MyClass" is a "Foo::Bar::MyClass"
#   Failed test 'Our "MyClass" is a "Foo::Bar::MyClass"'

#   at t\classes\07conflict_avoid.t line 75.
#          got: ''
#     expected: 'Foo::Bar::MyClass'
not ok 4 - Foo::Qux::MyClass->can('new')
#   Failed test 'Foo::Qux::MyClass->can('new')'

#   at t\classes\07conflict_avoid.t line 77.
#     Foo::Qux::MyClass->can('new') failed
not ok 5 - Foo::Qux::MyClass->new() died
#   Failed test 'Foo::Qux::MyClass->new() died'

#   at t\classes\07conflict_avoid.t line 79.
#     Error was:  Can't locate object method "new" via package "Foo::Qux::MyClass" (perhaps you forgot to load "Foo::Qux::MyClass"?) at C:/opt/perl-5.22.0/lib/
Test/More.pm line 690.
not ok 6 - Our "MyClass" is a "Foo::Qux::MyClass"
#   Failed test 'Our "MyClass" is a "Foo::Qux::MyClass"'

#   at t\classes\07conflict_avoid.t line 81.
#          got: ''
#     expected: 'Foo::Qux::MyClass'
Can't call method "fetch" on an undefined value at t\classes\07conflict_avoid.t line 83.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 2 just after 6.
Dubious, test returned 2 (wstat 512, 0x200)
Failed 6/6 subtests

Test Summary Report
-------------------
t\classes\07conflict_avoid.t (Wstat: 512 Tests: 6 Failed: 6)
  Failed tests:  1-6
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=1, Tests=6,  5 wallclock secs ( 0.06 usr +  0.01 sys =  0.08 CPU)
Result: FAIL

daoswald added a commit that referenced this pull request Aug 7, 2015
Fix test failure due to Windows style directory separators.
@daoswald daoswald merged commit 475fe3a into daoswald:master Aug 7, 2015
@daoswald
Copy link
Owner

daoswald commented Aug 7, 2015

This will be included in the next release of Inline::CPP to CPAN. (Will probably release over the weekend.) ...and thanks!

@nanis
Copy link
Contributor Author

nanis commented Aug 7, 2015

Thank you!

@wbraswell
Copy link
Contributor

@nanis
Is this also a potential fix for #30 ?

@mohawk2
Copy link
Collaborator

mohawk2 commented Aug 9, 2015

@wbraswell Since this PR has been merged and released, why don't you try it?

@nanis nanis deleted the nanis-fix-tests branch August 11, 2015 02:57
@wbraswell
Copy link
Contributor

@mohawk2
I can't test it, I only have Linux, why don't you try it and let us know?

@ToApolytoXaos
@bulk88
Can you please test this to see if it fixes the errors on your Windows system?

@stefanos82
Copy link

@wbraswell
I have tested it with cpanm and still fails. I will investigate it a bit more and will come back with further information.

I posted my error message on #30 by mistake, even though is related with that issue as well.

Is that alright with you guys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants