Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trapping reserved signals doesn't print a meaningful message #3208

Closed
kyrylo opened this issue Aug 1, 2015 · 1 comment
Closed

Trapping reserved signals doesn't print a meaningful message #3208

kyrylo opened this issue Aug 1, 2015 · 1 comment
Labels
core JRuby 9000
Milestone
JRuby 9.0.5.0

Comments

@kyrylo
Copy link
Contributor

kyrylo commented Aug 1, 2015

Let's trap a reserved signal:

trap(:ILL) {}

Output from MRI:

ArgumentError: can't trap reserved signal: SIGILL

Output from JRuby 9.0.0.0

ArgumentError: malformed format string - %S
from org/jruby/RubyString.java:1168:in `%'

It seems like JRuby tries to print the error, but fails for some reason.
Freaky added a commit to Freaky/jruby that referenced this issue Aug 1, 2015
@Freaky
Correct a format string in Signal#trap.
6a9fcf8 
Fixes jruby#3208: Trapping reserved signals doesn't print a meaningful
message
@Freaky
Copy link
Contributor

Freaky commented Aug 1, 2015

Simple format string error from holding down shift too long:

 raise ArgumentError.new("can't trap reserved signal: SIG%S" % sig)

@Freaky Freaky mentioned this issue Aug 1, 2015
Closed
kares pushed a commit to kares/jruby that referenced this issue Nov 13, 2015
@Freaky @kares
Correct a format string in Signal#trap.
c93b271 
Fixes jruby#3208: Trapping reserved signals doesn't print a meaningful
message
@kares kares closed this as completed in 18df48a Nov 13, 2015
@kares kares added this to the JRuby 9.0.5.0 milestone Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core JRuby 9000
Projects
None yet
Milestone
JRuby 9.0.5.0
Development

No branches or pull requests
4 participants
@rtyler @kares @Freaky @kyrylo