Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REXML failures when parsing SAML #1469

Closed
ylansegal opened this issue Feb 1, 2014 · 4 comments
Closed

REXML failures when parsing SAML #1469

ylansegal opened this issue Feb 1, 2014 · 4 comments
Milestone
Invalid or Duplicate

Comments

@ylansegal
Copy link

I am attempting to use the ruby-saml library with jruby. In my fork, I have made the appropriate changes to the gem to ensure that all tests are passing in MRI, but the XML parsing in jruby fails. Please take a look at the results in:

https://travis-ci.org/ylansegal/ruby-saml
https://travis-ci.org/ylansegal/ruby-saml/builds/18020223

All the failures seem to stem from REXML, but as far as I know that is part of the stdlib.

Can someone point me in the direction of the discrepancy?

Thanks,
@thujone
Copy link

thujone commented May 15, 2014

Did you ever get an answer for this? I'm curious, because I've read that ruby-saml doesn't work for jruby. Is that your experience?

@ylansegal
Copy link
Author

@thujone I never did get an answer for this.

I am using ruby-saml with jruby, but the tests don't pass. I created a branch based of https://github.com/onelogin/ruby-saml and this pull request SAML-Toolkits/ruby-saml#82

Even though the tests don't pass, when testing against actual SAML assertions from providers, it appears to behave as expected. It's not ideal, but it's the best I found

@thujone
Copy link

thujone commented May 4, 2015

If it interests anyone, the problem was that the version of Nokogiri used by ruby-saml did not support some of the jruby security methods properly. However, since then, Nokogiri has added support. We were able to overcome the issues we were having by simply upgrading to Nokogiri 2.6. For more info, see the jruby changelogs for Nokogiri.

ylansegal added a commit to ylansegal/ruby-saml that referenced this issue May 7, 2015
@ylansegal
Use a more modern Nokogiri for JRuby...
fbf0a4f 
More information:
jruby/jruby#1469 (comment)
ylansegal added a commit to ylansegal/ruby-saml that referenced this issue May 7, 2015
@ylansegal
Use a more modern Nokogiri for JRuby...
2e24b15 
More information:
jruby/jruby#1469 (comment)
ylansegal added a commit to ylansegal/ruby-saml that referenced this issue May 7, 2015
@ylansegal
Use a more modern Nokogiri for JRuby...
8ea1656 
More information:
jruby/jruby#1469 (comment)
ylansegal added a commit to ylansegal/ruby-saml that referenced this issue May 21, 2015
@ylansegal
Use a more modern Nokogiri for JRuby...
f78310c 
More information:
jruby/jruby#1469 (comment)
@rtyler
Copy link

rtyler commented Aug 7, 2015

Looks like this issue has been resolved outside of the project, so I"m going to go ahead and close it

@rtyler rtyler closed this as completed Aug 7, 2015
@enebo enebo added this to the Invalid or Duplicate milestone Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Invalid or Duplicate
Development

No branches or pull requests
4 participants
@enebo @rtyler @ylansegal @thujone