-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REXML failures when parsing SAML #1469
Comments
Did you ever get an answer for this? I'm curious, because I've read that ruby-saml doesn't work for jruby. Is that your experience? |
@thujone I never did get an answer for this. I am using ruby-saml with jruby, but the tests don't pass. I created a branch based of https://github.com/onelogin/ruby-saml and this pull request SAML-Toolkits/ruby-saml#82 Even though the tests don't pass, when testing against actual SAML assertions from providers, it appears to behave as expected. It's not ideal, but it's the best I found |
If it interests anyone, the problem was that the version of Nokogiri used by ruby-saml did not support some of the jruby security methods properly. However, since then, Nokogiri has added support. We were able to overcome the issues we were having by simply upgrading to Nokogiri 2.6. For more info, see the jruby changelogs for Nokogiri. |
More information: jruby/jruby#1469 (comment)
More information: jruby/jruby#1469 (comment)
More information: jruby/jruby#1469 (comment)
More information: jruby/jruby#1469 (comment)
Looks like this issue has been resolved outside of the project, so I"m going to go ahead and close it |
I am attempting to use the ruby-saml library with jruby. In my fork, I have made the appropriate changes to the gem to ensure that all tests are passing in MRI, but the XML parsing in jruby fails. Please take a look at the results in:
https://travis-ci.org/ylansegal/ruby-saml
https://travis-ci.org/ylansegal/ruby-saml/builds/18020223
All the failures seem to stem from REXML, but as far as I know that is part of the stdlib.
Can someone point me in the direction of the discrepancy?
Thanks,
The text was updated successfully, but these errors were encountered: