New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTML UI logic to support single-subject Binary resources #869
Conversation
I can't claim any significant experience with velocity templates, but I can confirm that the extra triples on binary resources aren't displayed in the HTML view after this patch is applied. However, I still see a "Other Resources" label at the bottom of the page, which is confusing. When I add a binary through the web interface, it creates a new resource with a Also, when I add a second version, as described in the ticket (update via I think this needs more work. |
@acoburn, the confusion seems to be coming from the fact that you tested PR-869 in isolation. PR-869 is not against |
@awoods unless I am mistaken, I did test #869 against #864. As for the single-subject issue on binary objects, that is, in fact fixed with this PR. My point, though, may be out of scope for (but not unrelated to) this ticket, namely that the same issue applies to the fcr:version interface, and that I still see a Other Resources header at the bottom of the page (with nothing below it) -- not a bug, just a confusing UI element. |
@ajs6f, I hope you are well and enjoying late summer. When you have a moment, could you please rebase this PR on master? |
Did you not see the question I just asked you in IRC? |
This PR is now being tracked on #864 |
Related to: https://jira.duraspace.org/browse/FCREPO-1640