Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tty issue with 1.7.2 (and 1.7.1), works in MRI #524

Closed
bcardarella opened this issue Feb 3, 2013 · 7 comments
Closed

tty issue with 1.7.2 (and 1.7.1), works in MRI #524

bcardarella opened this issue Feb 3, 2013 · 7 comments
Labels
Milestone

Comments

@bcardarella
Copy link

I'm getting an error in jruby that isn't happening in cruby 1.9.3. Here is the stack trace: https://gist.github.com/4700559 and line of code that is causing the failure https://github.com/dockyard/party_foul/blob/master/lib/generators/party_foul/install_generator.rb#L11 I'm not quite sure how to debug this

The strange thing is if I run the code that causes the issue in isolation: https://gist.github.com/4702733 it runs just fine with 1.7.2

@bcardarella
Copy link
Author

FYI this is on OSX 10.8.2 and Java version 1.6.0_37

@ghost
Copy link

ghost commented Feb 3, 2013

I have a feeling this is the same underlying issue as #511 - namely, not a problem with io/console.rb (as you demonstrated with the cut-down code sample), but with fileno mapping in JRuby not reflecting the actual underlying fileno.

Can you figure out if party_foul is doing anything like re-opening stdin/out/err?

@bcardarella
Copy link
Author

@wmeissner party_foul is using thor for a Rails generator which itself will make use of $stdin.gets in the ask_simply method: https://github.com/wycats/thor/blob/master/lib/thor/shell/basic.rb#L373

Other than that party_foul is not doing anything special.

@ghost
Copy link

ghost commented Feb 5, 2013

Can you try with jruby-head (or apply commit fc2d4e6 to jruby-1.7.2)?

@bcardarella
Copy link
Author

No effect, same error. I compiled from source and am on 1.7.3.dev

@BanzaiMan
Copy link
Member

@bcardarella Can I ask you to run git bisect to see if you can pinpoint the bad commit that introduced the problem?

Thank you.

@rtyler
Copy link

rtyler commented Aug 7, 2015

I believe this issue to be fixed, I've cloned the repository in question and run the tests on JRuby 9k and they work just fine on Debian/JDK8

➜  party_foul git:(master) rake test
Run options: --seed 13358

# Running tests:

.....................................................

Finished tests in 0.988000s, 53.6437 tests/s, 122.4696 assertions/s.

53 tests, 121 assertions, 0 failures, 0 errors, 0 skips
➜  party_foul git:(master) ruby -e "puts JRUBY_VERSION"
9.0.0.0
➜  party_foul git:(master) git log --oneline -n 1     
2678572 Merge pull request #114 from mkozono/prevent-exceptions
➜  party_foul git:(master) 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants