Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/milkymist
base: 6e8c7b1
Choose a base ref
...
head repository: m-labs/milkymist
compare: 3a7e212
Choose a head ref
  • 6 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 19, 2011

  1. softusb: partially unroll usb_in 

    This patch partially unrolls usb_in and takes decisions on the further
disposition of a packet at early as possible. The objective is to
minimize the processing needed between EOP of the DATAx packet and the
sending of an ACK.

The patch also changes error handling in two ways:

1) when deciding to discard a packet, always wait until the device
   really stops sending

2) packets with a garbled PID are treated as non-fatal errors
    @wpwrak
    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    016e556 View commit details
    Browse the repository at this point in the history

  2. softusb: send ACKs from dedicated inline function 

    To accelerate sending ACKs, this patch avoids the call setup overhead
of usb_tx and introduces a dedicated inline function. In experiments,
this reduced EOP-to-ACK time by about 10 full-speed bit times.
    @wpwrak
    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    f3023cf View commit details
    Browse the repository at this point in the history

  3. softusb: fail garbled packets fatally again 

    As the result of more testing that showed no degradation in performance,
this reverts to the original logic of failing garbled packets harder.
    @wpwrak
    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    f995f37 View commit details
    Browse the repository at this point in the history

  4. softusb: convert last remaining use of usb_rx to usb_rx_ack 

    Since usb_rx is now only used to receive ACK/NAK, we can replace it
with a more streamlined version. This should also marginally improve
error handling.
    @wpwrak
    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    8fcbc21 View commit details
    Browse the repository at this point in the history

  5. softusb: clear EPs on disconnect 

    Along with the logic to handle multiple interfaces, commit
a26dc51 also introduced the following
bug:

When a keyboard or composite device with keyboard was replaced by a
mouse after enumeration, the stack would still poll the "keyboard",
which most likely resulted in the mouse data to be b drained and
discarded.

This patch clears the EP roles on disconnect.
    @wpwrak
    wpwrak authored and Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    5695188 View commit details
    Browse the repository at this point in the history

  6. softusb: update copyright notice

    Sebastien Bourdeauducq committed Nov 19, 2011
    Copy the full SHA
    3a7e212 View commit details
    Browse the repository at this point in the history