Item13599: Don't skip files if no session

Extension installer tries to check-in topics that have history in the store, or are flagged to checkin in the manifest. When the installer is run from the CLI though, there is no session and checkin won't work, so it skips the file. Just copy the file if no session available.
foswiki · Aug 3, 2015 · 83229de · 83229de
1 parent cbceb8c
commit 83229de
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/core/lib/Foswiki/Configure/Package.pm b/core/lib/Foswiki/Configure/Package.pm
@@ -899,9 +899,12 @@ sub _install {
         my $perms = $manifest->{$file}->{perms};    # File permissions
 
         # Topic files in the data directory needing Checkin
-        # SMELL
+        # SMELL: This only can checkin when a SESSION exists. This won't
+        # work in CLI environment, so we are forced to skip this and just
+        # copy the file directly.
         if (
             $file =~ m/^data/    # File for the data directory
+            && $Foswiki::Plugins::SESSION
             && (
                 -e "$target,v"         # rcs history file exists
                 || -e "$target,pfv"    # pfv versions directory exists
@@ -944,7 +947,7 @@ sub _install {
                     next;
                 }
 
-                if ( $contents && $Foswiki::Plugins::SESSION ) {
+                if ($contents) {
                     $reporter->NOTE(
                         "> ${simulated}Checked in: $file  as $tweb.$ttopic")
                       if DEBUG;