Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 190e6a6eab48
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2402e859de33
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Aug 1, 2015

  1. Copy the full SHA
    c56b0cd View commit details
  2. Merge pull request #1038 from kachick/struct-each_pair

    Fix yield parameter of Struct#each_pair
    meh committed Aug 1, 2015
    Copy the full SHA
    2402e85 View commit details
Showing with 1 addition and 2 deletions.
  1. +1 −1 opal/corelib/struct.rb
  2. +0 −1 spec/filters/bugs/struct.rb
2 changes: 1 addition & 1 deletion opal/corelib/struct.rb
Original file line number Diff line number Diff line change
@@ -99,7 +99,7 @@ def each
def each_pair
return enum_for(:each_pair){self.size} unless block_given?

members.each { |name| yield name, self[name] }
members.each { |name| yield [name, self[name]] }
self
end

1 change: 0 additions & 1 deletion spec/filters/bugs/struct.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
opal_filter "Struct" do
fails "Struct#== handles recursive structures by returning false if a difference can be found"
fails "Struct#== returns true if the other has all the same fields"
fails "Struct#each_pair with a block variable passes an array to the given block"
fails "Struct#eql? handles recursive structures by returning false if a difference can be found"
fails "Struct#eql? returns false if any corresponding elements are not #eql?"
fails "Struct#hash returns the same fixnum for structs with the same content"