-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dir.foreach, Dir.new, Dir.open: Missing/incompatible encoding support. #3205
Comments
I would like to help on this. I did already some initial investigation and coding. |
I prepared initial fix but I have some observations and questions.
What's the recommended approach in this case?
correct syntax is I would like to continue with:
|
@MariuszCwikla Thanks for your help with this and #4495 (now fixed by #5915)! Your plan going forward looks fine to me, and I am standing by to offer any assistance I can. |
Just ran back into this with |
Steps toward resolving jruby#3205
I have pushed #6551 to try to unify this encoding logic and bring these methods into harmony. The available tests are no greener than they were before, but test/mri/ruby/test_dir_m17n runs now (was failing to load) and could be iterated on. |
@MariuszCwikla Dunno if you are still interested in helping here but going through the test_dir_m17n failures one by one might be fun! 😀 |
This is not ready and .15 will be coming out very soon. |
Ruby 2.2.2:
JRuby 9.0.0.0 yields, respectively:
The following works in JRuby:
But in Ruby 2.2.2 these raise:
It would seem the resolution to #2547 in 26ed114 is incorrect.
The text was updated successfully, but these errors were encountered: