Close any open selectors when tearing down a runtime. #3222
+62
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbrowning does it makes sense to turn the reproducer from the gist into a test case ? |
|
Perhaps - my only hesitation was I didn't see an easy way to get around needing a sleep in the test case to make sure the runtimes have all actually been torn down by the time we check for threads hanging around. |
|
+1 for doing this on jruby-1_7 as well |
bbrowning
added a commit
to torquebox/torquebox
that referenced
this pull request
Aug 10, 2015
All integration tests pass as long as first apply jruby/jruby#3222 and build JRuby from source. Once that PR is accepted upstream everything should be good without needing a custom build of JRuby. This branch of TorqueBox 3 is usable with JRuby 9.0.0.0 out of the box, but you will run into memory leaks over time as an application is redeployed until the issue referenced above is fixed.
This fixes a runtime leak in embedded scenarios where a runtime may never get garbage collected because it has a thread blocked on a select call. This leak exists in JRuby 1.7.x as well, but for some reason I'm seeing it more often in JRuby 9.x when running TorqueBox 3 integration tests. Perhaps there is more IO that uses select in 9.x than 1.7.x?
bbrowning
force-pushed
the
selector-leak
branch
from
e4563d4 to
ce7d531
Compare
|
I've rebased this on top of JRuby master and turned the reproducer into a test case per the suggestion by @mkristian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a runtime leak in embedded scenarios where a runtime may
never get garbage collected because it has a thread blocked on a
select call. This leak exists in JRuby 1.7.x as well, but for some
reason I'm seeing it more often in JRuby 9.x when running TorqueBox 3
integration tests. Perhaps there is more IO that uses select in 9.x
than 1.7.x?
Here's a gist with a fairly simple reproducer and results on 1.7.21, 9.0.0.0, and 9.0.1.0-SNAPSHOT with this patch applied - https://gist.github.com/bbrowning/3cbb3901d4facd7fc99f