HTML UI: Ensure resource creation URIs have no double '/' chars #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var base = $('#main').attr('resource'); | ||
|
|
||
| // Remove trailing '/' if it exists | ||
| var cleanedBase = base.lastIndexOf('/') == base.length - 1 ? base.substr(0, base.length - 1) : base; |
There was a problem hiding this comment.
Would it ever be possible that the resource attribute would end in two "/" characters? This JS code will remove a single trailing slash, but not more than one.
There was a problem hiding this comment.
I do not believe the resource can currently find itself in a double '/' situation... but I can add a while-ends-with-slash function to prevent such an issue in the future.
There was a problem hiding this comment.
If you're confident that resource won't end in multiple slashes, we can leave it as-is; otherwise, adding the additional function makes sense to me.
acoburn
added a commit
that referenced
this pull request
Aug 8, 2015
|
Resolved via 51545e1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://jira.duraspace.org/browse/FCREPO-1677