treat port nil as 0 for pack_sockaddr_in #3219
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
same here, please add the spec/ruby/library/socket/shared/pack_sockaddr.rb change in a separate commit |
|
... also maybe you could instead open a PR targeting jruby-1_7 ... otherwise we'll have to cherry-pick |
|
@kares not a problem - it's also an issue on master, so should I send two? |
This change treats it as 0 per MRI Ruby
reuben-sutton
force-pushed
the
fix_pack_sockaddr_incompatability
branch
from
ddbb929 to
b6960a5
Compare
|
great thanks, for the future if you only target 1_7 it will eventually end up in master as well with the merge |
kares
added a commit
that referenced
this pull request
Aug 6, 2015
…tability treat port nil as 0 for pack_sockaddr_in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure compatability with MRI Ruby
closes #3156