... on my way to update the doc ...

👎I think this way of doing was a technical debt in eight. This prevents those logs to be exported to splunk or logstash like the other logs.
Or to have the logs in stdio in docker.
Probably a compromise would be to make this optional.

the test broke anyway, not enough mocking there ...

@tardyp:

• I don't understand your point about logstash and splunk, they are especially meant to handle logs from different files !
• About docker logging, why not providing twisted.log on stdio and http.log on stderr like nginx does there: https://github.com/nginxinc/docker-nginx/blob/master/Dockerfile#L13 ?

Travis should be happy now ...

What I do with logstash and splunk is that I directly send the log data in json form from the python logging system to the log server. without going to files. something similar to:
https://github.com/exoscale/python-logstash-formatter/blob/master/logstash_formatter/__init__.py
I actually have something fancier that does async tcp via twisted, but is compatible with sync python log system.

The twistd.log logging is supposed to be configured in buildbot.tac. I think what you can do with buildbot.tac is not documented enough. You can really do neat stuff.

For docker/heroku/paas, this is the same thing, you can configure this in the buildbot.tac:
https://github.com/tardyp/buildbot-heroku/blob/master/master/buildbot.tac

Forcing to go through files is the good old way. That's why splunk is so good at it. It works, but this is uneeded I/O for me.

👎 for documenting the buildbot.tac and having to support more of those kind of crazy setups ! Our goal is to make buildbot accessible, not to constrain ourselves to some borderline usages.

At the moment, the twisted.log file is literally polluted by the http logs. This happened in eight, there was a discussion about it, a bug was filled (http://trac.buildbot.net/ticket/684), and the consensus was to provide a http.log file. I'm not sure we should have that discussion again. And I'm pretty sure one of your buildbot.tac trick will allow you to continue do the same while we will help more basic users dig through their logs ...

I agree that there should be an easy way, and a more configurable way.

I'm just asking that this http.log is more configurable. best log practices changed since 5 years ago. So yes this is something that for me should be discussed.

my proposal:

``logfileName``
    Filename used for http logs. Relative to master.cfg directory
    defaults to 'http.log'
    if None, http logs are not handled differently from other logs, and will go to `twistd.log`    

``logRotateLength``
    The amount of bytes after which the :file:`http.log` file will be rotated.
   (Default to the same value as for the :file:`twisted.log` file, set in :file:`buildbot.tac`)

``maxRotatedFiles``
    The amount of log files that will be kept when rotating
    (Default to the same value as for the :file:`twisted.log` file, set in :file:`buildbot.tac`)

if logfileName is set to None, then the class Site() is used instead of RotateLogSite, and I'm happy.

Ok, fine. Let's do it that way.

Let's review that one again !

As a side note, this should be fixed now that we have configurations (not new in this PR) to allow reconfig to work.
[This is not something I broke or introduced in this PR, hence not fixing it there]

The tests are failing, and I think previous had some pep8 issues
👍 for the rest. thanks!