Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 139dbe8bb709
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 447b61191a02
Choose a head ref
  • 6 commits
  • 6 files changed
  • 3 contributors

Commits on Jun 18, 2015

  1. test: support writing test output to file

    This is a minimal effort to support test output written both to
    stdout and file in order to get our buildbots understanding
    test output.
    
    Cherry picked from jbergstroem/node@3194073
    Original commit metadata follows:
      PR-URL: nodejs/node#934
      Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
      Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    
    Reviewed-By: Dummy Reviewer <review@me.org>
    PR-URL: #25541
    jbergstroem authored and orangemocha committed Jun 18, 2015
    Copy the full SHA
    028aa38 View commit details
    Browse the repository at this point in the history
  2. build: disable v8 snapshots

    Snapshots speed up start-up by a few milliseconds but are potentially
    dangerous because of the fixed hash seed that is used for strings and
    dictionaries, making collision denial-of-service attacks possible.
    
    Release builds on iojs.org have snapshots disabled but source builds
    did not, until now.
    
    The risk for individual source builds is low; the binary gets a random
    32 bits hash seed that should be hard to guess by an external attacker.
    
    It's when binaries are distributed by, for example, a distro vendor
    that the fixed hash seed becomes a vulnerability, because then it's
    possible to target a large group of people at once.
    
    People that really need the faster start-up time can use the new
    --with-snapshot configure flag.
    
    Cherry picked from bnoordhuis/io.js@4f68369
    Original commit metadata below:
      PR-URL: nodejs/node#585
      Reviewed-By: Bert Belder <bertbelder@gmail.com>
      Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
      Reviewed-By: Rod Vagg <rod@vagg.org>
    
    Reviewed-By: Dummy Reviewer <review@me.org>
    PR-URL: #25541
    bnoordhuis authored and orangemocha committed Jun 18, 2015
    Copy the full SHA
    0aaff08 View commit details
    Browse the repository at this point in the history
  3. build: support Jenkins via test-ci

    Reviewed-By: Dummy Reviewer <review@me.org>
    PR-URL: #25541
    orangemocha committed Jun 18, 2015
    Copy the full SHA
    99edcce View commit details
    Browse the repository at this point in the history
  4. tools: pass constant to logger instead of string

    On a few of our installations (namely CentOS), passing 'INFO'
    resulted in a silent loglevel. Use a logging constant instead.
    
    Cherry-picked from nodejs/node@8606793
    Original commit metadata follows:
      Fixes: nodejs/build#104
      PR-URL: nodejs/node#1842
      Reviewed-By: Rod Vagg <rod@vagg.org>
    
    Reviewed-By: Dummy Reviewer <review@me.org>
    PR-URL: #25541
    jbergstroem authored and orangemocha committed Jun 18, 2015
    Copy the full SHA
    ccb5e38 View commit details
    Browse the repository at this point in the history
  5. build: don't run lint from test-ci

    Since we will run linting before compiling or testing there's no
    need to run it as part of the ci testing.
    
    Cherry-picked from nodejs/node@8d8a26e
    Original commit metadata follows:
      PR-URL: nodejs/node#1965
      Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
      Revewied-By: Evan Lucas <evanlucas@me.com>
    
    Reviewed-By: Dummy Reviewer <review@me.org>
    PR-URL: #25541
    jbergstroem authored and orangemocha committed Jun 18, 2015
    Copy the full SHA
    e15e6cc View commit details
    Browse the repository at this point in the history
  6. build: remove lint from test-ci on windows

    There is now a sepearate linter job taking care of
    running jslint.
    
    See nodejs/node#2004
    
    Reviewed-By: Dummy Reviewer <review@me.org>
    PR-URL: #25541
    orangemocha committed Jun 18, 2015
    Copy the full SHA
    447b611 View commit details
    Browse the repository at this point in the history