Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all uses of approx() in the tests have the tolerance argument #127

Closed
zmughal opened this issue Jun 21, 2015 · 1 comment
Closed

Comments

@zmughal
Copy link
Member

zmughal commented Jun 21, 2015

See t/bad.t's ABSTOL constant:

# although approx() caches the tolerance value, we
# use it in every call just to document things

Or create an isapprox() that shows the values when the assertion fails and requires setting the appropriate epsilon value. See Test::PDL for inspiration.

@zmughal
Copy link
Member Author

zmughal commented Jan 2, 2022

I'll revisit this issue later when I do more work on the tests.

@zmughal zmughal closed this as completed Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant