core/commands: Make IpnsCmd and PublishCmd public

wking · wking · commit 40c6ffd4feef · 2015-06-19T02:44:03.000-07:00
ipfs-shell [1] accesses the Command objects directly to construct requests for an external IPFS daemon API. This isn't a terribly robust approach, because it doesn't handle version differences between the version of go-ipfs used to build the daemon and the version used to build the ipfs-shell-consuming application. But for cases where you can get those APIs to match it works well. Making these two commands public allows us to write ipfs-shell wrappers for them. Until we figure out how to get ipfs-shell working without access to core/commands, I think the best approach is to make future command objects and their returned structures public, and to go back and expose existing commands/structures on an as-needed basis. In this case, I need the public PublishCmd for the Docker-registry storage driver, and I made the IpnsCmd public at the same time to stay consistent for both 'ipfs name ...' sub-commands. [1]: https://github.com/whyrusleeping/ipfs-shell License: MIT Signed-off-by: W. Trevor King <wking@tremily.us>
diff --git a/core/commands/ipns.go b/core/commands/ipns.go
@@ -10,7 +10,7 @@ import (
 	u "github.com/ipfs/go-ipfs/util"
 )
 
-var ipnsCmd = &cmds.Command{
+var IpnsCmd = &cmds.Command{
 	Helptext: cmds.HelpText{
 		Tagline: "Gets the value currently published at an IPNS name",
 		ShortDescription: `
diff --git a/core/commands/name.go b/core/commands/name.go
@@ -51,7 +51,7 @@ Resolve the value of another name:
 	},
 
 	Subcommands: map[string]*cmds.Command{
-		"publish": publishCmd,
-		"resolve": ipnsCmd,
+		"publish": PublishCmd,
+		"resolve": IpnsCmd,
 	},
 }
diff --git a/core/commands/publish.go b/core/commands/publish.go
@@ -17,7 +17,7 @@ import (
 
 var errNotOnline = errors.New("This command must be run in online mode. Try running 'ipfs daemon' first.")
 
-var publishCmd = &cmds.Command{
+var PublishCmd = &cmds.Command{
 	Helptext: cmds.HelpText{
 		Tagline: "Publish an object to IPNS",
 		ShortDescription: `

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ import (`
`10`	`10`	`u "github.com/ipfs/go-ipfs/util"`
`11`	`11`	`)`
`12`	`12`
`13`		`-var ipnsCmd = &cmds.Command{`
	`13`	`+var IpnsCmd = &cmds.Command{`
`14`	`14`	`Helptext: cmds.HelpText{`
`15`	`15`	`Tagline: "Gets the value currently published at an IPNS name",`
`16`	`16`	ShortDescription: `
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ Resolve the value of another name:`
`51`	`51`	`},`
`52`	`52`
`53`	`53`	`Subcommands: map[string]*cmds.Command{`
`54`		`- "publish": publishCmd,`
`55`		`- "resolve": ipnsCmd,`
	`54`	`+ "publish": PublishCmd,`
	`55`	`+ "resolve": IpnsCmd,`
`56`	`56`	`},`
`57`	`57`	`}`