New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relaxed referential integrity rules for RELS-INT. #25
Conversation
@@ -19,7 +19,7 @@ | |||
</foxml:datastreamVersion> | |||
</foxml:datastream> | |||
<foxml:datastream ID="DS0" STATE="A" CONTROL_GROUP="X" VERSIONABLE="false"> | |||
<foxml:datastreamVersion ID="DS0.0" LABEL="Example Managed binary datastream" CREATED="2015-05-13T19:51:09.487Z" MIMETYPE="text/xml" SIZE="30"> | |||
<foxml:datastreamVersion ID="DS0.0" LABEL="Example Managed binary datastream" CREATED="2015-05-13T19:51:09.488Z" MIMETYPE="text/xml" SIZE="30"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this update designed to affect the integration tests to demonstrate the issue of a DS not yet being created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This change duplicates the conditions in which the issue occurs, and without the changes above (or something comparable) the integration test will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Can you reach out to @bcail for verification. Then we can merge this.
It would be good to get @bcail's verification of this PR. |
The test looks good to me, although I haven't actually run the new code. I guess for testing the PR I'd need to clone Mike's repo & use the maven system? How often are new jars created? |
@bcail, download the executable jar from here: The readme may also be helpful: |
I cloned Mike's repo & ran it on my data with the mvn command. I'm getting the following (different) error: |
Could you copy the line 439 of your BsaicObjectVersionHandler @bcail so I can figure out what's null? |
439 updateResourceProperties(ds, triplesToRemove, triplesToInsert); |
@bcail I'm sorry I can't seem to figure out what's wrong. I'm not sure how that line could result in a NPE, since no objects are dereferenced. |
@mikedurbin maybe ds is null? In any case, though, there's a unit test - maybe the PR should just be merged. I can try again with the latest master after it's merged... |
@mikedurbin, do we merge this? |
It's possible (likely) there's an outstanding bug that results in the NullPointerException, whether it was introduced by this commit or not is unclear. I'm pretty sure this PR addresses the issue described in the ticket. |
So yeah... if you're asking me... let's merge it and move on to the next issue people run across. |
Relaxed referential integrity rules for RELS-INT.
Resolves https://jira.duraspace.org/browse/FCREPO-1585