Make sure install script line endings don't get confused on Windows #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks reasonable. We just need verification from one of the committers that they see the issue and the fix. |
|
I don't have a Windows system to test this on, but I can verify that there were several people here trying to spin up the vagrant on Windows who ran into problems. We should probably also add SSH as a requirement since that doesn't get handled or reported well (installing Git and having git/bin in the path fixed this). |
|
We had a similar issue in Islandora Vagrant, and we solved it with Islandora-Labs/islandora_vagrant@388dc02. The solution looks similar, so I'd be comfortable with merging. |
|
@osmandin, can you verify that fcrepo4-vagrant does not work for you on a Windows box without this PR? |
|
@osmandin were you ever able to verify? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #14